Debug Failure. Did not expect ObjectLiteralExpression to have an Identifier in its trivia about typescript HOT 7 OPEN

It is, yes. That's a valid identifier.

from typescript.

Likely this is failing due to the fact that the scanner/parser always pass in the script target, while much of services always asks for the latest.

But, I think this setup is not quite right. If the target is ES5, then we use the older table when parsing and doing stuff. But that doesn't feel right. Our inputs should be permissive, allowing anything, then erroring later if we can't downlevel it. In this case, there actually is a downleveling that works, and esbuild uses it unconditionally (even though it only does ES6+):

var G = { "\u{1D504}": "𝔄" }

Unfortunately just removing the ES5 table is not sufficient as without the scanner/parser to complain, we get no errors. A better change would need to preserve the table but only for emit errors. Or, in the parser, always parse identifiers with Latest then error on them if the script target is ES5 and the scanned text doesn't pass ES5 (which would at least stop the crashing, I think).

from typescript.

Obviously TS shouldn't crash, but is this legal JS?

from typescript.

We haven't updated the unicode tables in a while, which may be the problem, but, I haven't tested yet.

from typescript.

Target es5 is crucial here. You have 2 unicode tables there - it doesnt crash with newer targets

from typescript.

I thought \u{1D504} was ES6+ syntax and doesn't work in ES5. Am I misremembering?

from typescript.

Could be, I'm no historian 😅

from typescript.