[Errors] Empty object contextually typed by type with indexer about typescript HOT 11 CLOSED

The actual behavior here matches the spec. It appears to be by design.

from typescript.

Another interesting example where we don't error, but probably should:

var v: { [s: string]: string} = {
p: 3, // Expect an error here
q: null
}

This is a result of best common type losing information, and the nontransitivity of assignability.

from typescript.

What's the action here? If we're aligned to spec, shouldn't this just be closed as by design?

from typescript.

As I recall from discussion, the spec needs to be updated to align with the current behavior. Specifically, I think section 3.8.1 needs to not pull in call/construct/index signatures for the augmented types.

And it is a breaking change.

from typescript.

I'm confused. You mention earlier that the "actual behavior here matches the spec. It appears to be by design." If so, is there a spec change?

from typescript.

Yeah my previous comments were wrong because I misunderstood what was going on. Ignore those. It needs a spec change per my recent comment.

from typescript.

Before we make this change, please confirm that the change does not impact real world code before we make the spec change.

from typescript.

Reopening this because the validation on real world code was not done yet.

from typescript.

Doesn't break any real world code we know of.

from typescript.

Is this fixed, or by design?

from typescript.

Fixed, in that it is a change from the old compiler. Spec has been updated to reflect behavior of the new compiler.

from typescript.