Giter Club home page Giter Club logo

Comments (12)

marcosfede avatar marcosfede commented on August 25, 2024 2

Same issue here, but I'm opening the whole monorepo in vscode

tslint.json
packages/
  package1/
    tsconfig.json   

linter is not working and it did with the old extension

from typescript-tslint-plugin.

mjbvz avatar mjbvz commented on August 25, 2024

In that example, which folder have you opened in the editor?

from typescript-tslint-plugin.

xaviergonz avatar xaviergonz commented on August 25, 2024

A source file inside packages/a/src

from typescript-tslint-plugin.

mjbvz avatar mjbvz commented on August 25, 2024

Did you only open a single file in your editor? Or an entire subfolder?

from typescript-tslint-plugin.

xaviergonz avatar xaviergonz commented on August 25, 2024

a single .ts file

from typescript-tslint-plugin.

xaviergonz avatar xaviergonz commented on August 25, 2024

Also, maybe unrelated, when the tslint.json location is set in the plugins section of the tsconfig.json pointing to the root folder, if vscode is closed and reopened again then tslint won't work until such tsconfig.json file is resaved.

When using the extends trick it is ok.

from typescript-tslint-plugin.

xaviergonz avatar xaviergonz commented on August 25, 2024

Btw, what I mean by a single .ts file is that the workspace is pointing to the root, and then I double click on that single .ts file to open it.

from typescript-tslint-plugin.

xaviergonz avatar xaviergonz commented on August 25, 2024

If you want a proper example just clone this repo for example:
https://github.com/mobxjs/mobx-state-tree
then open the folder with vscode, run yarn and open any ts file inside packages\mobx-state-tree\src

from typescript-tslint-plugin.

xaviergonz avatar xaviergonz commented on August 25, 2024

A commit was just done to use tslint.json that extends to the root one, so if you clone that repo you may want to use this branch for example instead: https://github.com/mobxjs/mobx-state-tree/tree/better-liveliness-warning

from typescript-tslint-plugin.

itanex avatar itanex commented on August 25, 2024

I am also experiencing this with descending tslint files

Project is an ASP.NET Core project with Angular 6.X.X

/tsconfig.json
/ClientApp/tsconfig.json (A)
/ClientApp/src/tsconfig.json (B)


/ClientApp/tsconfig.json (A)

{
  "defaultSeverity": "error",
  "extends": "tslint:recommended",
  "jsRules": {},
  "rules": {  },
  "rulesDirectory": []
}

/ClientApp/tsconfig.json (B)

{
  "extends": "../tslint.json",
  "rules": {
    "component-selector": [
      true,
      "element",
      "app",
      "kebab-case"
    ],
    "directive-selector": [
      true,
      "attribute",
      "app",
      "camelCase"
    ]
  },
  "linterOptions": {
    "exclude": [
      "test.ts",
      "main.ts",
      "polyfills.ts"
    ]
  }
}

When I run the CLI or through Visual Studio with tslint-microsoft-contrib the excluded files are not excluded as expected. Which leads me to believe it is not being loaded in reference to the directory it sits in.

from typescript-tslint-plugin.

mjbvz avatar mjbvz commented on August 25, 2024

@xaviergonz Looks like that branch no longer exists. Do you have a link to version of that project where it doesn't work?

from typescript-tslint-plugin.

mjbvz avatar mjbvz commented on August 25, 2024

Closing as TSLint has been deprecated in favor of ESLint. We are archiving this repo as this project is no longer maintained

from typescript-tslint-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.