Giter Club home page Giter Club logo

Comments (2)

bryanmacfarlane avatar bryanmacfarlane commented on July 17, 2024

we already went through OSS process, worked with author for compliance to copy.

But, to make sure I understand, this is asserting we pull the full httpntlm (ntlm code along with http functionality we won't use. We considered that but they we coupled a bit. Perhaps a PR would make your point better instead of pasting a diff that we can't run.

Note that we have another issue to add back ntlm and we plan on re-introducing with async await so I don't think we will use httpntlm as is.

from typed-rest-client.

peterblazejewicz avatar peterblazejewicz commented on July 17, 2024

@bryanmacfarlane I've got your point now. I understand the reason why there is a copy of source file directly now (I've checked the file commit history but it is short and simply does not contain relevant bits of information).
I've run a diff on the file content and see the changes you've added, so there is no point of this discussion any longer I think. Thanks!

from typed-rest-client.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.