Comments (5)
stephenmichaelf
commented on September 18, 2024
Agreed this seems like a bug.
I am not sure we need to provide the option to allow a custom processor function. It will be either JSON or a string, right? We could try both then fail.
from typed-rest-client.
mmajcica
commented on September 18, 2024
That's right. I'll give it a try.
from typed-rest-client.
mmajcica
commented on September 18, 2024
In is not trully a bug, but it is expecting the body to always be a JSON response. Unfortunatelly, in this non perfect world, we have API's that do replay JSON objects in case all goes well, however, in case of the exceptions the do just replay the error message as a string in the body.
What I would suggest is to expect response with status code minor then 300 to be a JSON. Meanwhile in case of errors to pick up the consider also strings as JSON in the response.
Does this sound resonable?
from typed-rest-client.
mmajcica
commented on September 18, 2024
In this way we do not break compatibility and add the possiblity to accept the error messages as strings.
from typed-rest-client.
damccorm
commented on September 18, 2024
Closing since this was resolved by #124
from typed-rest-client.
Related Issues (20)
- Sending body with delete request HOT 3
- Underscore 1.12.1 being used shows vulnerability https://npmjs.com/advisories/1674
- Possible regression in proxy variable processing HOT 4
- SyntaxError: Invalid regular expression: invalid group specifier name HOT 3
- Confusing deprecation: "1.8.5 contains changes that are not compatible with Node 6" HOT 3
- Update Azure pipeline and remove GitHub action HOT 2
- Authentication header is set on redirect request HOT 1
- ETIMEDOUT for certain calls on Node 16 HOT 5
- Performance issues with readBody in HttpClient.ts HOT 3
- error from zlib not handled properly in decompressGzippedContent() HOT 4
- This repo is missing important files
- Unable to read error message from response header HOT 3
- uncaught reference error: the process does not define in browser HOT 11
- not working with react with next js , HOT 3
- Discussion: use with fetch API HOT 5
- Incorrect header check error while decompressing a response HOT 2
- Chrome 113 breaks typed-rest-client HOT 3
- Please tag released versions HOT 4
- Add `EHOSTUNREACH` to `NetworkRetryErrors` list HOT 1
- Add support to REST client for getting binary data HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from typed-rest-client.