match is a valid method name about tolerant-php-parser HOT 2 CLOSED

From #365 and #366:

Needs to be added in TokenStringMaps under KEYWORDS array.
https://www.php.net/manual/en/reserved.keywords.php

What that page actually says:

The following words cannot be used as [global] constants, class names, or [global] function names. They are, however, allowed as property, constant, and method names of classes, interfaces and traits, […].

from tolerant-php-parser.

Hm.. I misinterpeted the PR at #366. Whilst preparing a revert with test case locally, I realized the test was failing and passing in the opposite direction as I expected. Turns out PR #366 isn't causing match to be seen as a match operator, rather it is merely turning the token from known to unknown. tolerant-php-parser already knew to allow "keyword" tokens as legal method names, so all is well.

From phan/phan#4751:

It seems the uptream issue at #392 was already fixed back in June 2022, before I reported this issue here issue. The fix was released in tolerant-php-parser v0.1.2 on 5 Oct 2022, and Phan's main branch was updated the same day, phan/phan@cc66093.

However, it remained unreleased for several months, until the Phan 5.4.2 release in March 2023. https://github.com/phan/phan/releases/tag/5.4.2

The example code now analyzes without error https://phan.github.io/demo/. Closing as such. Thanks!

I believe this report can likewise we closed a well.

from tolerant-php-parser.