Comments (4)
jeffersonking
commented on August 17, 2024
Fixed in 76c5bf2,
f239a93, and 779316d.
from sarif-web-component.
commented on August 17, 2024
Hi Jeff,
In @michaelfanning's review of the samples PR, he argued -- and I agree -- that if a suppression is still under review, it should be hidden until it is explicitly rejected. So please change the logic as follows:
IF there are no suppressions OR all suppressions are rejected THEN
show it
ELSE
// There is at least one suppression that has not been rejected: either it has been accepted,
// or it is still under review, or it has no status.
hide it
ENDIF
from sarif-web-component.
commented on August 17, 2024
@harleenkohli, why did you reopen this? Did you see the same issue in @jeffersonking's latest extension?
from sarif-web-component.
commented on August 17, 2024
Ok, I understand now -- re-closing.
from sarif-web-component.
Related Issues (20)
- Don't duplicate rule.id/rule.name HOT 1
- FilterBar flickers and doesnt actually open if embedded in material ui HOT 8
- Display "review HOT 1
- Display "review" results as warnings
- Wrong number of characters highlighted HOT 1
- Not able to dismiss the tooltip of "Clear Filters" button and "1" control using the "Esc" key HOT 1
- When "Unsuppressed" and "Suppressed" control receives the keyboard focus, the color contrast ratio of border with respect to background is less than 3:1. HOT 3
- Incorrect control type "Group" exist for "Filter" control. HOT 3
- Keyboard focus is not visible on "Path", "Details" and "WS1138: UseHttpOnlyCookieAttribute" controls in high contrast mode. HOT 1
- Incorrect heading level is provided for "WebScout" and "Recommendation" headings. HOT 4
- Support for SARIF v1 HOT 1
- Branch data from versionControlProvenance is not processed HOT 1
- Apply Syntax Hilighting to Code Snippets HOT 2
- If a snippet is not included no line/column information is shown HOT 2
- Add filtering based on Rule, Tag, and Result Kind HOT 2
- Bug: Latest github-pages deployment does not support Azure DevOps (ADO) line numbers (deep linking) HOT 5
- Move the `docs` folder to it's own repository.
- This repo is missing important files
- Is the property 'codeFlows' supported?
- [Sarif Validator] Source code frame is too small with SARIF1008 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sarif-web-component.