Comments (10)
Similar issue happens with
--to
. I can see how--only
is not always safe, but-to
should be, and installing only a subset of deps would really help reduce the time installing (specifically in CI where you don't have previously installed deps like on local )
I encountered a similar problem. After we upgraded pnpm7 to pnpm8, rush install --to projectName no longer installs the dependencies of the project specified by --to. After execution, all dependencies of the entire monorepo are installed. I would like to ask if anyone has the same problem.
rush version: 5.115.0
pnpm version: 8.15.6
If I revert back to pnpm7, everything will be normal.
from rushstack.
This seems like a recent regression. @dmichon-msft - can you take a look at this, since you refactored the project selection logic? This may have been broken by recent changes to the installation algorithm. @g-chao, @william2958 - Would you two mind taking a look at this as well, as you guys changed this logic most recently?
from rushstack.
Do we know which Rush version introduced this regression?
from rushstack.
Notice that @elenasch cited Rush 5.112.2 which is from December. Is this really a regression? Maybe it is just an edge case.
I'm actually unclear what rush install --only .
is meant to do by design. Is it even valid? π€
from rushstack.
It might make sense to forbid the unsafe selectors (--only
, --impacted-by
, --impacted-by-except
) for rush install
and rush update
.
@dmichon-msft what do you think?
from rushstack.
Similar issue happens with --to
. I can see how --only
is not always safe, but -to
should be, and installing only a subset of deps would really help reduce the time installing (specifically in CI where you don't have previously installed deps like on local )
from rushstack.
If you run with --debug
it should log the command being forwarded to pnpm
. Are the --filter
arguments not showing up in that command?
from rushstack.
It looks like it is there. Are there any other settings that look out of place ?
Invoking package manager: <my path>/.rush/node-v20.10.0/pnpm-8.13.1/node_modules/pnpm/bin/pnpm.cjs install --store <my path>/common/temp/pnpm-store --config.cacheDir= <my path>/common/temp/pnpm-store --config.stateDir= <my path>/common/temp/pnpm-store --no-prefer-frozen-lockfile --reporter ndjson --no-strict-peer-dependencies --config.auto-install-peers=false --config.resolutionMode=highest --config.ignoreCompatibilityDb --recursive --link-workspace-packages false --filter my-npm-package...
from rushstack.
@dmichon-msft I ran just the raw pnpm
command I posted above, and it did the right thing with only installing the one project in filter (took about 5.5s) , then ran the rush install --only .
and it took ~54s.
from rushstack.
@hx-dl I encountered the same problem and created an issue last year already which links to the related issue on pnpm side: #4218
from rushstack.
Related Issues (20)
- [@rushstack/terminal] Remove support for the legacy `IColorableSequence` objects.
- [heft-jest] In watch mode, changedFiles should only remove files that match before/after the run HOT 1
- [heft-typescript] Bound current directory in sys.watchFile and sys.watchDirectory
- [rush] Make `install` and `update` log package manager to a file in common/temp
- [api-documenter]
- [rush] Find rush.json location by using 'dirname' at most 10 times HOT 8
- [api-extractor] Allow generation of API reports per release level HOT 1
- [api-extractor] Internal Error: Unable to follow symbol for "Set" HOT 1
- [eslint-patch] Upgrade to ESLint 9 HOT 4
- [rush] Latest Node LTS security patch for spawnSync breaks rush on Windows HOT 1
- [rush] Medium - <CVE-2024-28863> -6.5 - Vulnerability in βtar6.1.15β HOT 1
- [api-extractor] Union types extracted from declaration files are unstable
- [rush] tab-complete fails to complete project list after `--to` HOT 1
- [api-extractor] Better support for nominal types
- [rush] rush add -p <package> always installs as if `--all` is specified HOT 3
- [heft] `set-environment-variables-plugin` variables remain set in unrelated phases
- [rush] The source code address for the 'rush build' command.
- [rush] Cannot publish: getting ENEEDAUTH even though I'm already authenticated HOT 2
- [rush] PNPM Overrides with more advanced syntax will cause Rush to always complain that shrinkwrap file need to be updated HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rushstack.