treeShaking causing a crash with react-native-reanimated about rnx-kit HOT 9 CLOSED

created the bug report: software-mansion/react-native-reanimated#5311

from rnx-kit.

We'd really appreciate it if you can make a minimal repro.

from rnx-kit.

I did some further digging into this - seems like it is related to @react-navigation/drawer. When I stripped out the Drawer navigator from our app it is not crashing anymore. I assume they use a condition somewhere in their code which the treeShaking ignores and strips out something that it actually needs from reanimated.
https://reactnavigation.org/docs/upgrading-from-5.x/#drawer-now-uses-reanimated-2-if-available

but still working on the repro project

from rnx-kit.

When I stripped out the Drawer navigator from our app it is not crashing anymore. I assume they use a condition somewhere in their code which the treeShaking ignores and strips out something that it actually needs from reanimated.

It sounds like @react-navigation/drawer or one of its dependencies are declaring sideEffects: false when they shouldn't. You can try removing the line in package.json to see if it fixes the crash.

from rnx-kit.

What version of @react-navigation/drawer are you using @adamivancza? Try 6.5.1

from rnx-kit.

Oh, I think I found the reason - https://github.com/software-mansion/react-native-reanimated/blob/main/package.json
this has some sideEffects here which I assume is web only (based on git blame) so treeshaking excludes some stuff for the app that we would need. after changing that to plain true our app works just fine. Not entirely sure how to proceed after this though. I can't patch package.json via patch-package...

from rnx-kit.

Oh, I think I found the reason - https://github.com/software-mansion/react-native-reanimated/blob/main/package.json this has some sideEffects here which I assume is web only (based on git blame) so treeshaking excludes some stuff for the app that we would need.

Two things come to mind:

• Are the files listed in sideEffects missing in the bundle i.e. is this a bug in our serializer?
• If not, should that list include more files? If the sideEffects array is missing files, we should fix that upstream.

from rnx-kit.

Oh, I think I found the reason - https://github.com/software-mansion/react-native-reanimated/blob/main/package.json this has some sideEffects here which I assume is web only (based on git blame) so treeshaking excludes some stuff for the app that we would need.

Two things come to mind:

• Are the files listed in sideEffects missing in the bundle i.e. is this a bug in our serializer?
• If not, should that list include more files? If the sideEffects array is missing files, we should fix that upstream.

The sideEffects seems to be completely wrong for react-native as after installing this lib I do not have the listed libraries at all:

from rnx-kit.

I'm gonna close this one and open a bug report inside react-native-reanimated

from rnx-kit.