Remove FlatList.windows.js Fork about react-native-windows HOT 1 OPEN

This was because y’all were adding a babel transform outside the Metro preset, which ran before stripping Flow types. It is unrelated to any code changes, and is related to some syntax ambiguity for Flow typing a property vs later ES syntax to add a member. If transform runs before we strip the type, it turns into a new member which can shadow the old one, instead of being a no-op in the transformed code.

It will not happen with the transform removed, so it’s probably fixed already since that didn’t make it into what was eventually committed when integrating the changes.

As referenced, we did also very recently change the code to be resilient to custom transforms operating before type stripping, since incorrect transforms are hard to debug, and customizing a babel config isn’t an uncommon use case. We got a lot of PRs from folks trying random code changes to fix the issue, and it looks like the final commit message for changing FlatList was not updated with the context from the discussion on the PR itself.

The actual code here is years old, but the babel transforms are now more relevant, and misconfigurations have become much more common.

from react-native-windows.