Giter Club home page Giter Club logo

Comments (1)

likewei92 avatar likewei92 commented on July 28, 2024

Actually an input could also potentially be just a unit (would be a bit weird but lets's say someone just wanted 1eV, he can just put spu.eV which is of type unit rather than Mul. 1* spu.eV would be Mul because that's a multiplication).

In general I almost feel like trying to do type checking in python is a bit of a fool's errand (for e.g. if you assert that your input needs to be float, it could break if someone passes in a np.float64, but for all intents and purposes the input is correct and would have worked if not for the assertion). I think it would be sufficient to pass the input to to_float, and if it blows up we could catch that exception and give a more helpful error message, like "Input was not in the correct unit! expected unit is ..."

from qmt.

Related Issues (16)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.