Giter Club home page Giter Club logo

Comments (4)

alexcjohnson avatar alexcjohnson commented on July 17, 2024

Interesting, numpy does a whole bunch of stuff to bake the version (including the git revision) into the build. Their primary source of the version numbers actually seems to be setup.py itself, but then the reading of version.py comes in if you run setup.py on a copy of numpy that has already had write_version_py run... which I guess is what they post to pypi?

Another model is eg plotly.py - where a version.py is read by both setup.py and __init__.py

This is a whole lot simpler, and I'd think it would suffice for our needs. The only thing missing is the git commit id - we've talked about logging this when you run commands. For that purpose it doesn't really need to be part of qcodes.__version__, and I think for the most part if people have qcodes installed as a regular package they should be using a released version (so major.minor.patch is a unique identifier) and if they have it installed as a dev version, they'll have it in a cloned git repo and we can read the revision the same way as numpy's git_version

from qcodes.

peendebak avatar peendebak commented on July 17, 2024

@alexcjohnson The plotly model is indeed simpler. I implemented it and accidentally committed to master instead of a new branch.

Shall we keep the commit to master and close the issue?

from qcodes.

alexcjohnson avatar alexcjohnson commented on July 17, 2024

Sure, looks good. We still need a qcodes/version.py right? But then I'm happy to close this.

from qcodes.

peendebak avatar peendebak commented on July 17, 2024

Just added version.py, I'll close the issue

from qcodes.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.