NotificationMapping constructor should accept "." when asking for notifications over the whole repo about projfs-managed-api HOT 7 CLOSED

@SteveBenz, @wilbaker
I've had a while to think about this and I just don't agree. Specifying . is an error. The only case where . makes sense to specify a relative path is when you're using a command shell to specify a path relative to the current directory. "Current directory" isn't a file system concept, so it doesn't belong in ProjFS.

I'm going to change this fix to an exception. The VirtualizationInstance constructor already throws exceptions, so adding a new one isn't a big deal.

from projfs-managed-api.

@wilbaker I'm willing to make this change since I plan to also allow the native API to accept .. It will mean that for a while the native and managed APIs behave slightly differently, but I don't think it is enough of a difference to be a big deal.

Besides, if people coming from a non file-system background assume . is valid and that causes them to, without warning, not get any notifications, that is problematic.

from projfs-managed-api.

For various reasons (mainly to do with us having originally approached ProjFS from the mindset that a provider is an extension of the file system) the underlying native API expects "" to mean the virtualization root. I can add code to the managed wrapper that converts . to "" for consumption by the native API.

I'll also file a work item to add support for . to the native API to make things simpler for native developers in the future.

from projfs-managed-api.

For various reasons (mainly to do with us having originally approached ProjFS from the mindset that a provider is an extension of the file system) the underlying native API expects "" to mean the virtualization root. I can add code to the managed wrapper that converts . to "" for consumption by the native API.

FWIW I think it would be OK to say that the managed API will match the native API here not convert . to "".

Historically the goal has been to keep the managed layer thin and consistent with the managed API, and I'm not sure it's good to have them start diverging when it comes to core behavior/functionality.

from projfs-managed-api.

I'm happy with throwing an exception if the user passes "." or even ".\path". Much better than silently getting no notifications, and I see that you've updated the parameter's documentation to clearly call it out.

But the fix for #26 doesn't look right to me. I could have a folder called ".git" and want to specifically see activity within that folder but not other folders. Looks to me like if I pass ".git" as a folder name, it'll fail and there'll be no way to specifically monitor that.

from projfs-managed-api.

#26 now throws an exception only for paths that are exactly . or that start with .\.

from projfs-managed-api.

@SteveBenz @wilbaker
The nuget feed has been updated with these changes.

from projfs-managed-api.