Character restrictions for item ID about product-recommendations HOT 4 CLOSED

Hi @marcin-synak ,
I think the system should work with any string, albeit one might need to escape it if some item id is passed in the URL (like in some API).
You could defiantly modify the code locally to do that, build and update your existing service\create a new service, see Deploying New Code to the Deployed Solution

from product-recommendations.

Hello @natinimni,
Thanks for the answer. We are familiar with deploying procedure. We've updated our solution at least twice if I remember correctly.

Of course, we could modify the code ourselves and remove the offending lines ;) We were just unsure if there were any internal reasons preventing us from doing it (it's hard to say without analyzing the whole source). URL encoding etc is basic stuff. I also assume any valid CSV file (with quotes, escape characters etc) would work.

But, to be honest, we're not thrilled with the idea of maintaining our own version of the code.
Is there a chance such change could hit the master branch? If it's not harmful?

from product-recommendations.

Hi @marcin-synak ,

looking back a the source, I don't think it should be a problem. Item ids are indexed into integers before being sent to the underlying engine so I cannot see any blocker to remove char restriction from item ids.

Feel free to contribute this and any other useful changes you maintain locally back to the master branch, I can approve your pull request. I hope that's alright.
Thanks!

from product-recommendations.

Thanks Nati, I've created a pull request with my changes.

This is the first time I'm using Git and Github, I hope I did everything right :)

from product-recommendations.