Giter Club home page Giter Club logo

Comments (4)

skottmckay avatar skottmckay commented on June 25, 2024

Do you have a model where this causes an issue?

from onnxruntime.

chenfeiyue-cfy avatar chenfeiyue-cfy commented on June 25, 2024

Sure, the model is downloaded from onnx model zoo:(https://github.com/onnx/models/blob/main/validated/vision/classification/densenet-121/model/densenet-12-int8.onnx).
The unit test is from path onnxruntime/onnxruntime/test/contrib_ops/qlinear_concat_test.cc(https://github.com/microsoft/onnxruntime/blob/main/onnxruntime/test/contrib_ops/qlinear_concat_test.cc)

from onnxruntime.

skottmckay avatar skottmckay commented on June 25, 2024

I don't think the lack of support makes a difference in this case.

QLinearConcat is an internal operator, so we would expect it to be handled by our internal execution providers. In that scenario, the fact that the zp/scale values aren't nicely provided by the NodeUnit doesn't change anything as nothing (AFAIK) is trying to read the zp and scale from the NodeUnit as we have static kernels for CPU/CUDA/DML execution providers to handle QLinearConcat.

Really for the model to be in the ONNX repo it should be in QDQ format (DequantizeLinear on each input with a Concat node and a QuantizeLinear on the output) instead of having been saved using internal onnxruntime operators. With that model format any execution provider could convert the set of nodes into a quantized concat operation, and it would want the zp/scale for the inputs to be conveniently available via the NodeUnit. That's a different NodeUnit constructor though and not the path with the TODO comment.

from onnxruntime.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.