Comments (4)
Do you have a model where this causes an issue?
from onnxruntime.
Sure, the model is downloaded from onnx model zoo:(https://github.com/onnx/models/blob/main/validated/vision/classification/densenet-121/model/densenet-12-int8.onnx).
The unit test is from path onnxruntime/onnxruntime/test/contrib_ops/qlinear_concat_test.cc(https://github.com/microsoft/onnxruntime/blob/main/onnxruntime/test/contrib_ops/qlinear_concat_test.cc)
from onnxruntime.
I don't think the lack of support makes a difference in this case.
QLinearConcat is an internal operator, so we would expect it to be handled by our internal execution providers. In that scenario, the fact that the zp/scale values aren't nicely provided by the NodeUnit doesn't change anything as nothing (AFAIK) is trying to read the zp and scale from the NodeUnit as we have static kernels for CPU/CUDA/DML execution providers to handle QLinearConcat.
Really for the model to be in the ONNX repo it should be in QDQ format (DequantizeLinear on each input with a Concat node and a QuantizeLinear on the output) instead of having been saved using internal onnxruntime operators. With that model format any execution provider could convert the set of nodes into a quantized concat operation, and it would want the zp/scale for the inputs to be conveniently available via the NodeUnit. That's a different NodeUnit constructor though and not the path with the TODO comment.
from onnxruntime.
Related Issues (20)
- [Mobile] android prod crash: signal 11 (SIGSEGV), code 1 (SEGV_MAPERR) HOT 2
- [Feature Request] prebuilt package with cudnn 9 support HOT 1
- [Build] support for CPython 3.13.0b1
- [Feature Request] why is `FunctionProto` missing from the file "onnxruntime/core/providers/shared_library/provider_wrappedtypes.h"? HOT 3
- [Build] Dockerfile.tensorrt out of date HOT 3
- [Web] I canβt use onnruntime-web to load a onnx model in a react web HOT 5
- Unauthorized for `onnxruntime-cuda-12/pypi/simple/`
- [Documentation] The documentation for early versions is missing HOT 2
- pip install failure for onnxruntime==1.17.3 HOT 1
- Index put loop model regression with ort==1.18
- Non-zero status code returned while running Add node. Name:'Add_221'
- can't install on Python HOT 1
- Error in quantize vicuna-7b model from fp16 to int8 HOT 4
- Issue of UNet Model Inference with [model.onnx + model.onnx_data] in ONNX Runtime C++ for Stable Diffusion HOT 9
- Gemm fp8 run error HOT 3
- Where is onnxruntime-openvino==1.18.0 HOT 3
- [.NET] Update tensor implementations to new Tensor<T> type
- [Web] WebGPU and WASM Backends Unavailable within Service Worker HOT 5
- ONNXruntime version 1.18.0 HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from onnxruntime.