[Build] Debug build is broken with TensorRT EP about onnxruntime HOT 7 CLOSED

@JulienTheron
Could you help change the build script here ?
-or (args.use_tensorrt and args.use_tensorrt_oss_parser)
+or args.use_tensorrt
to use protobuf?

The issue is because when building Debug on Windows, ORT will implicitly use oss onnx-tensorrt parser rather than built-in parser due to known issue of msvc. And oss onnx-tensorrt requires protobuf not protobuf-lite.

from onnxruntime.

We will have a fix for it.
And for the upcoming TRT 10 GA, onnx-tensorrt parser will support protobuf-lite and TRT EP can then move to protobuf-lite completely.

from onnxruntime.

Thanks for the quick response. I think the issue is linked to #20368. I will try to build the correct tag and will get back to you.

from onnxruntime.

It seems QSpectre is enabled by default now, unless --enable_address_sanitizer is set.
I'm not sure if this is by design, but I updated my build script to replace --disable_memleak_checker with --enable_address_sanitizer and the build succeeded!
Thanks.

from onnxruntime.

I just found out that enabling the address sanitizer is not a good solution for us as it relies on the presense of clang_rt.asan_dynamic-x86_64.dll at runtime, which is not a good idea when you ship a DLL to your users.
So currently, we're stuck with being forced to enable QSpectre when building ORT v1.17.3, which breaks the build as those prerequisites are not installed with Visual Studio by default.
Any idea if this can be fixed before 1.18?

from onnxruntime.

Could you help change the build script here ?
-or (args.use_tensorrt and args.use_tensorrt_oss_parser)
+or args.use_tensorrt

just wondering did you try above?

i can repro from my side and this issue is because of using protobuf-lite when building the onnx-tensorrt parser.

update: had a PR for this issue.

from onnxruntime.

Yes I did try your fix and it works fine on the main branch, but it's not applicable for 1.17.3 as the build script is different.
The issue now is that QSpectre is always enabled when building 1.17.3. I think I'll open a new issue for that.
Thanks.

from onnxruntime.