Giter Club home page Giter Club logo

Comments (26)

deltakosh avatar deltakosh commented on August 25, 2024 1

I'm controlling this API but I know no straightforward way of removing _ layer.

But I'm certainly sure we are not the only API relying on this pattern.

So for all of these API we need to develop a tool to "clean" the definition file

from monaco-editor.

alexdima avatar alexdima commented on August 25, 2024 1

This might be helpful specifically for TypeScript.

from monaco-editor.

alexdima avatar alexdima commented on August 25, 2024

@jrieken @joaomoreno Do you know how/if this is feasible to add to the API ?

from monaco-editor.

jrieken avatar jrieken commented on August 25, 2024

That's not possible unless you tackle the provider of the suggestions, say TypeScript language service etc

from monaco-editor.

deltakosh avatar deltakosh commented on August 25, 2024

It was possible in the preview versions

from monaco-editor.

deltakosh avatar deltakosh commented on August 25, 2024

up?

from monaco-editor.

jrieken avatar jrieken commented on August 25, 2024

@deltakosh It is still not possible unless you use your own provider. Do you need help to implement/add your own provider?

from monaco-editor.

deltakosh avatar deltakosh commented on August 25, 2024

Any help would be greatly appreciated:) I just need the regular provider without _ properties and functions

from monaco-editor.

jrieken avatar jrieken commented on August 25, 2024

I just need the regular provider without _ properties and functions

Do I assume correctly that you have added a some_lib.d.ts file that defines such symbols? Iff so why is it like that?

from monaco-editor.

deltakosh avatar deltakosh commented on August 25, 2024

We added a custom d.ts where _ define private properties and functions

from monaco-editor.

jrieken avatar jrieken commented on August 25, 2024

where _ define private properties and functions

So, why adding them and then filtering them again?

from monaco-editor.

deltakosh avatar deltakosh commented on August 25, 2024

Do you really suggest that I manually remove all _properties from my d.ts?
Here is the file: https://github.com/BabylonJS/Babylon.js/blob/master/dist/babylon.2.4.d.ts

from monaco-editor.

jrieken avatar jrieken commented on August 25, 2024

No, my question is why does the d.ts contains symbols with _ if those aren't desired. Do you control that API? Is it just a file you need to process? Is the API two fold and public layer and a private aka _ layer?

You are failing to motivate why we should enable to filter suggestions globally in the editor while it seems to be you that's controlling those suggestions anyways?

from monaco-editor.

deltakosh avatar deltakosh commented on August 25, 2024

Note: Some _ must be flagged as public as there is no internal in TS

from monaco-editor.

deltakosh avatar deltakosh commented on August 25, 2024

Any thoughts?

from monaco-editor.

deltakosh avatar deltakosh commented on August 25, 2024

I guess I failed to explain my issue. Se please let me try again:

  • we are generating our Babylon.d.ts from our typescript source files
  • private properties are by convention preceded by a _
  • unfortunately as there is no internal keyword in typescript, we have to flag some _ properties as public

Hopefully this is clearer now:)

from monaco-editor.

deltakosh avatar deltakosh commented on August 25, 2024

up?

from monaco-editor.

deltakosh avatar deltakosh commented on August 25, 2024

up?

from monaco-editor.

meulta avatar meulta commented on August 25, 2024

Do you have news on this?

from monaco-editor.

davrous avatar davrous commented on August 25, 2024

I'm also interested in this feature! Any news on that?

from monaco-editor.

julien-moreau avatar julien-moreau commented on August 25, 2024

Right ! Do you have any news about that ?

from monaco-editor.

sebavan avatar sebavan commented on August 25, 2024

I have the same issue, any ETA ?

from monaco-editor.

kpau avatar kpau commented on August 25, 2024

Note: Some _ must be flagged as public as there is no internal in TS

TypeScript compiler supports stripInternal option. It should work in your case.
http://www.typescriptlang.org/docs/handbook/compiler-options.html

from monaco-editor.

deltakosh avatar deltakosh commented on August 25, 2024

The problem is that babylon.js library is pretty big now and adding /** @internal */ JSDoc annotation to all _ properties and methods is not an option

from monaco-editor.

deltakosh avatar deltakosh commented on August 25, 2024

Apparently the 0.18 is now displaying properties flagged as private. Is that expected?

from monaco-editor.

atifsyedali avatar atifsyedali commented on August 25, 2024

In my case I just want to remove the undefined option from the list, without disabling variables. Don't want to implement a completion provider just to filter out one item from the list.

from monaco-editor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.