Giter Club home page Giter Club logo

Comments (8)

ksaur avatar ksaur commented on May 25, 2024 1

Since it seems they likely changed something internally (now it appears there is a one-node tree rather than a three-node tree), this will take a bit more time. Let's not block the release on this for now.

from hummingbird.

ksaur avatar ksaur commented on May 25, 2024

Before, I believe they were defaulting to objective="rank:pairwise" but that doesn't seem to fix this.
Also, we'll need an upstream fix from onnxmltools for the 1 onnx XBG error.

Started troubleshooting at #733

Pinning this for now.

from hummingbird.

ksaur avatar ksaur commented on May 25, 2024

onnxmltools was updated but let's wait for their release, then do ours

from hummingbird.

ksaur avatar ksaur commented on May 25, 2024

With the onnxmltools patch, we now get some new errors:
==== 19 failed, 516 passed, 105 skipped, 115 warnings in 294.32s (0:04:54) ====

Some of them are related to the ndcg change

FAILED ....Check failed: label_is_valid: Relevance degress 
must be lesser than or equal to 31 when the exponential NDCG gain function is used. 
Set `ndcg_exp_gain` to false to use custom DCG gain.

but many are just outright wrong: Mismatched elements: 100 / 100 (100%) ...

from hummingbird.

ksaur avatar ksaur commented on May 25, 2024

The problem is related to convert_sklearn_xgb_regressor's

tree_infos = operator.raw_operator.get_booster().get_dump()

from hummingbird.

ksaur avatar ksaur commented on May 25, 2024

With xgb==1.7.6, for get_dump() we have '0:[f0<0.84472543] yes=1,no=2,missing=1\n\t1:leaf=-0.0600000024\n\t2:leaf=0.100000009\n',

whereas with xgb==2.0.0 we have '0:leaf=2.36637643e-09\n' from get_dump()

Then at:

return TreeParameters(lefts, rights, features, thresholds, values)

the values for TreeParameters(lefts, rights, features, thresholds, values) are incorrect

from hummingbird.

ksaur avatar ksaur commented on May 25, 2024

TODO: look at onnx/onnxmltools#597 more closely

from hummingbird.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.