Giter Club home page Giter Club logo

Comments (7)

mikewheaton avatar mikewheaton commented on May 10, 2024

This would also fix a related issue. In the screenshot below you can see the Dropdown inside of a container with overflow: hidden set. The Dropdown is cut off, because it's contents haven't been lifted out via the LayerHost that Callout and other components use.

image

from fluentui.

dzearing avatar dzearing commented on May 10, 2024

Yes please.

from fluentui.

dzearing avatar dzearing commented on May 10, 2024

Micah - if you can find time for this, it's low hanging fruit!

from fluentui.

micahgodbolt avatar micahgodbolt commented on May 10, 2024

I actually already took a first crack at this. Let me see where it's at and push up a PR for review.

from fluentui.

micahgodbolt avatar micahgodbolt commented on May 10, 2024

#446 is my initial PR. I've moved over to using the callout, but there are several issues I still need to overcome.

  1. Because it is on a different layer, the width cannot be assumed. Need to determine best way to measure this.
  2. Due to multiple ways to close the dropdown (click on input and regular callout scroll/click outside etc) the dropdown isn't closing properly when you click the input box. Basically the callback fires before the click function has a chance to test "is-closed". Means you can't close it via click.
  3. More cleanup around the change of styling and functionality.

from fluentui.

micahgodbolt avatar micahgodbolt commented on May 10, 2024

I'm trying to wrap up the tooltip, so rather than going down this rabbit hole, I'm going to leave it here until I'm done. If someone else wants to finish up, feel free.

from fluentui.

dzearing avatar dzearing commented on May 10, 2024

This is now checked in.

from fluentui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.