Comments (8)
I've been spiking this, and the problem as I see it is two fold.
-
Configuration providers are generally meant to be pretty static in nature. You load all configuration at once. Yes, you can reload, and yes it is possible with a bunch of work to make it work fully dynamically (though GetChildKeys may make it difficult for some providers), but this is pretty non-trivial stuff for this to feel like an abstraction like MEDI and MEL are.
-
At the configuration level we're missing context to be able to use existing feature flag backends. For instance, with Launch Darkly you can't interrogate a flag without having a user. Some hacky "access global state" approach might work here, but that approach is ugly at best.
Configuration should be a provider, not the only provider, and the provider abstraction should include context hooks.
from featuremanagement-dotnet.
Hey @christogav it's a good suggestion. We are still working on some features that may result in tweaks to the current API surface. Once we finalize all of those items we can shift toward exposing the internals to make the library more open as you have described.
from featuremanagement-dotnet.
Hi @jimmyca15 ,
Could we please get visibility into the WIP features or is everything captured by https://github.com/microsoft/FeatureManagement-Dotnet/issues/created_by/jimmyca15?
Also I'd like to get an idea of when this lib might be considered stable..?
Thanks!
from featuremanagement-dotnet.
Likewise, very interested to know when this is considered stable so we can start using it. I'm also interested in using it with external vendors. @christogav Out of interest, what are the interfaces you'd like to see made public?
from featuremanagement-dotnet.
We have a couple of breaking changes in the dev branch awaiting a release.
Currently we don't expect any breaking changes after that and after the release of these features we plan to give it a little bit of time for final feedback then release a stable version. All changes on top of that will be additive.
from featuremanagement-dotnet.
@josephwoodward Looks like IFeatureSettingsProvider is the main one. There may be others but I haven't looked in detail.
from featuremanagement-dotnet.
Given the original inquiry:
We'd like to propose that some of the interfaces be made public so we can switch out their implementations...
It doesn't seem to me this should be necessary to integrate with FFaaS providers, given that:
Any .NET Core configuration provider is capable of acting as the back-bone for feature flags.
as stated in the README.
IOW, would it make more sense to create a custom .NET Core configuration provider for, say, LaunchDarkly or whichever?
from featuremanagement-dotnet.
This has been added in the latest release.
from featuremanagement-dotnet.
Related Issues (20)
- The TargetingId should be included in the FeatureEvaluation event even if it's null/empty. HOT 5
- Targeting evaluation is CPU dependent. HOT 4
- Remove the support for variants and telemetry from the .NET feature flag schema HOT 14
- Include Targeting Information on outgoing telemetry HOT 2
- Support .NET 8 Targeting framework in Microsoft.FeatureManagement.Telemetry.ApplicationInsights.AspNetCore
- Target netstandard2.* in Microsoft.FeatureManagement.Telemetry.ApplicationInsights
- The approach to telemetry (using custom `ITelemetryPublisher`) seems overengineered and counter to modern OpenTelemetry abstractions HOT 37
- Add Default Http Targeting Context Accessor
- Consider moving `TargetingHttpContextMiddleware` to the App Insights package HOT 2
- No instance of ITargetingContextAccessor is available for variant assignment. HOT 6
- FeatureManagerSnapshot should snapshot TargetingContext as well
- EvaluationDataToApplicationInsights example
- Can't Set FeatureFilters In FeatureManager In .NET Framework Application HOT 10
- Update Package metadata
- Add a link to preview on main readme HOT 1
- Cannot use the TargetingFilter in .NET class library project HOT 3
- Nuget "Microsoft.FeatureManagement.AspNetCore" Version 3.3.0 - Multiple feature filters match the configured filter named 'Microsoft.TimeWindow' HOT 8
- Consider using `TimeProvider` using Microsoft.Bcl.TimeProvider nuget package HOT 2
- Bug 4.0.0-preview: NullReferenceException when TargetingContext.UserId is null and TargetingEvaluationOption.IgnoreCase = true
- Consider the ability to allocate variants based on custom filters HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from featuremanagement-dotnet.