Comments (6)
zhenlan
commented on July 27, 2024
1
A potential solution is to allow customization of the behavior when a flag is not found. By default, the flag is considered false, but a user can change the default to true or throw.
from featuremanagement-dotnet.
jimmyca15
commented on July 27, 2024
1
Enabled in release 2.4.0
from featuremanagement-dotnet.
josephwoodward
commented on July 27, 2024
A potential solution is to allow customization of the behavior when a flag is not found. By default, the flag is considered false, but a user can change the default to true or throw.
I agree, this seems like a better solution.
from featuremanagement-dotnet.
jimmyca15
commented on July 27, 2024
I believe we should add a new error type to FeatureManagementError. The type can be MissingFeature. Once we have the new error, we can throw a FeatureManagementException when a call for a missing feature occurs. We can then offer a switch in FeatureManagementOptions to control the new behavior.
If the behavior is on by default then it is a breaking change so it would need to be done in a major version bump.
from featuremanagement-dotnet.
josephwoodward
commented on July 27, 2024
@jimmyca15 I have a draft PR here for this change, interested in any feedback before I continue on this approach.
from featuremanagement-dotnet.
maplemale
commented on July 27, 2024
Any chance this can be bumped / moved forward? Looks there was a PR with comments and it is now stale with conflicts?
from featuremanagement-dotnet.
Related Issues (20)
- The TargetingId should be included in the FeatureEvaluation event even if it's null/empty. HOT 5
- Targeting evaluation is CPU dependent. HOT 4
- Remove the support for variants and telemetry from the .NET feature flag schema HOT 14
- Include Targeting Information on outgoing telemetry HOT 2
- Support .NET 8 Targeting framework in Microsoft.FeatureManagement.Telemetry.ApplicationInsights.AspNetCore
- Target netstandard2.* in Microsoft.FeatureManagement.Telemetry.ApplicationInsights
- The approach to telemetry (using custom `ITelemetryPublisher`) seems overengineered and counter to modern OpenTelemetry abstractions HOT 37
- Add Default Http Targeting Context Accessor
- Consider moving `TargetingHttpContextMiddleware` to the App Insights package HOT 2
- No instance of ITargetingContextAccessor is available for variant assignment. HOT 6
- FeatureManagerSnapshot should snapshot TargetingContext as well
- EvaluationDataToApplicationInsights example
- Can't Set FeatureFilters In FeatureManager In .NET Framework Application HOT 10
- Update Package metadata
- Add a link to preview on main readme HOT 1
- Cannot use the TargetingFilter in .NET class library project HOT 3
- Nuget "Microsoft.FeatureManagement.AspNetCore" Version 3.3.0 - Multiple feature filters match the configured filter named 'Microsoft.TimeWindow' HOT 8
- Consider using `TimeProvider` using Microsoft.Bcl.TimeProvider nuget package HOT 2
- Bug 4.0.0-preview: NullReferenceException when TargetingContext.UserId is null and TargetingEvaluationOption.IgnoreCase = true
- Consider the ability to allocate variants based on custom filters HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from featuremanagement-dotnet.