Add optional location information to Variables about debug-adapter-protocol HOT 5 CLOSED

we could definitely linkify variable values that look like locations (either file paths or URIs, URIs would be more general.)

This does already work today, you can cmd+click the value of [[FunctionLocation]]

from debug-adapter-protocol.

This seems like pretty limited applicability. I wonder if there's a simpler way to fix it up just for the case with a function, for example, in vscode we have a link detector on variable values, and if you include a location: "/path/file.js:123" property on the function, users can cmd+click to jump there.

Related, @minsa110 was asking for a "go to definition" from the variables explorer in notebooks. It's a little more practical in that context because most variables come from a single document and maybe one can reverse engineer the locations on demand.

from debug-adapter-protocol.

V8 does give us a magic [[FunctionLocation]] internal property. I don't really like the idea of treating 'magic properties' specially, but we could definitely linkify variable values that look like locations (either file paths or URIs, URIs would be more general.) And we could parse URIs that are children of the debug sessions's workspace folder to look a bit nicer.

I like that solution more than my proposal 😛

from debug-adapter-protocol.

Oh yeah, we have #343 already :)

from debug-adapter-protocol.

@roblourens I was not able to cmd+click the value of [[FunctionLocation]] in VSCode JS debugger when debugging an extension even though I see the source location. Has this made to the released version of VSCode?

from debug-adapter-protocol.