Comments (11)
@giorgi-ghviniashvili here is a sample spec, and how it looks now:
zoomed_summary.mov
The zoom kind of works, but since the axis is shared between the last few frames it doesn't update with the new range.
from datamations.
@sharlagelfand Seems like this is gemini issue that it does not update axis. Let me take a look why.
from datamations.
OK, fixed it. It was not correctly drawing vega-axis
layer.
y-axis-fix.mov
from datamations.
Thanks @giorgi-ghviniashvili! This looks great. I tried it with error bars as well but it looks like they're drawn twice or something, could you take a look? Here are the specs.
double_errorbar.mov
from datamations.
@sharlagelfand sorry, forgot to clear old container, here it is:
error-bars.mov
from datamations.
Thanks, looks good!!
from datamations.
Going to reopen this since it looks like there's an issue with zooming on errorbars when there are no facets, as in this spec:
no_facets_errorbar_off_on_zoom.mov
from datamations.
Sad.. It is gemini thing, not able to correctly update y axis.. Trying to figure it out, whether it is a gemini bug or ours.
from datamations.
@sharlagelfand, so the reason of the issue is because we have different y-axis on last two specs.
Ok, I fixed it and now it correctly updates y-axis when animating last frame.
Ok, thats good. Now bad news, it does not correctly change width (to shift x-axis because of floating points) and still getting this:
Gemini recommend does same in gemini-editor, it just expands axis to the left:
I tried to add this to gemini spec manually in code after recommend
{
"component": "view",
"change": {
"signal": [
"width", "height"
]
},
"timing": {
"duration": {
"ratio": 1
}
}
}
and seems like it worked:
zoom-error-bars-fix.mov
from datamations.
It looks good to me now, thanks @giorgi-ghviniashvili!
Just curious, do you know why the sizing of axes changes and overlaps in Firefox, but not in Chrome? Everything looks pretty nice in Chrome:
chrome.mov
But a bit rough in Firefox (my main browser):
firefoxc.mov
from datamations.
No Idea, will try to debug and see why.
from datamations.
Related Issues (20)
- Update Javascript documentation HOT 4
- Get python to parity with R updates HOT 1
- JS code as npm package and write unit tests HOT 1
- Clean up final error bars on zoom HOT 1
- Penguins example looks funny HOT 15
- Update package version to resolve dependabot security warning
- Penguins example breaks with 2 or 3 variables in shiny app HOT 2
- Find a spot for the updated shiny app HOT 1
- R-CMD-check workflow failing HOT 1
- This repo is missing important files
- ESLint workflow failing
- Pylint workflow failing HOT 1
- Implementation of Min and Max aggregation functions in JavaScript HOT 1
- Implementation of Sum and Product aggregation functions in JavaScript HOT 1
- Implementation of Count and Count Numbers aggregation functions in JavaScript HOT 1
- Implement Count and Quantile in Python
- Implement Min and Max in Python HOT 1
- Implement Sum and Product in Python HOT 1
- Respect factor orderings HOT 1
- Supported R version
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from datamations.