Giter Club home page Giter Club logo

Comments (11)

sharlagelfand avatar sharlagelfand commented on May 18, 2024

@giorgi-ghviniashvili here is a sample spec, and how it looks now:

zoomed_summary.mov

The zoom kind of works, but since the axis is shared between the last few frames it doesn't update with the new range.

from datamations.

giorgi-ghviniashvili avatar giorgi-ghviniashvili commented on May 18, 2024

@sharlagelfand Seems like this is gemini issue that it does not update axis. Let me take a look why.

from datamations.

giorgi-ghviniashvili avatar giorgi-ghviniashvili commented on May 18, 2024

OK, fixed it. It was not correctly drawing vega-axis layer.

y-axis-fix.mov

from datamations.

sharlagelfand avatar sharlagelfand commented on May 18, 2024

Thanks @giorgi-ghviniashvili! This looks great. I tried it with error bars as well but it looks like they're drawn twice or something, could you take a look? Here are the specs.

double_errorbar.mov

from datamations.

giorgi-ghviniashvili avatar giorgi-ghviniashvili commented on May 18, 2024

@sharlagelfand sorry, forgot to clear old container, here it is:

error-bars.mov

from datamations.

sharlagelfand avatar sharlagelfand commented on May 18, 2024

Thanks, looks good!!

from datamations.

sharlagelfand avatar sharlagelfand commented on May 18, 2024

Going to reopen this since it looks like there's an issue with zooming on errorbars when there are no facets, as in this spec:

no_facets_errorbar_off_on_zoom.mov

from datamations.

giorgi-ghviniashvili avatar giorgi-ghviniashvili commented on May 18, 2024

Sad.. It is gemini thing, not able to correctly update y axis.. Trying to figure it out, whether it is a gemini bug or ours.

from datamations.

giorgi-ghviniashvili avatar giorgi-ghviniashvili commented on May 18, 2024

@sharlagelfand, so the reason of the issue is because we have different y-axis on last two specs.

Ok, I fixed it and now it correctly updates y-axis when animating last frame.


Ok, thats good. Now bad news, it does not correctly change width (to shift x-axis because of floating points) and still getting this:

image

Gemini recommend does same in gemini-editor, it just expands axis to the left:

e71bae0a-dff8-432c-8205-6b616a9f40b5


I tried to add this to gemini spec manually in code after recommend

{
    "component": "view",
    "change": {
      "signal": [
        "width", "height"
      ]
    },
    "timing": {
          "duration": {
              "ratio": 1
          }
      }
  }

and seems like it worked:

zoom-error-bars-fix.mov

from datamations.

sharlagelfand avatar sharlagelfand commented on May 18, 2024

It looks good to me now, thanks @giorgi-ghviniashvili!

Just curious, do you know why the sizing of axes changes and overlaps in Firefox, but not in Chrome? Everything looks pretty nice in Chrome:

chrome.mov

But a bit rough in Firefox (my main browser):

firefoxc.mov

from datamations.

giorgi-ghviniashvili avatar giorgi-ghviniashvili commented on May 18, 2024

No Idea, will try to debug and see why.

from datamations.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.