Comments (3)
Thanks for describing more about what you were thinking. But I don't think we're going to go with that. If we find many more types that could fit the same pattern it might be worth it, but as a one-off case, this is too much customization to be worthwhile IMO.
from cswin32.
I'm afraid this is unlikely to be 'fixed' because types like CREDENTIALW
are not mere handles. SafeHandle can only represent an IntPtr
. Even if we derived from it to add more fields, as a class it couldn't stand in for the CREDENTIALW
struct where methods took pointers to it.
from cswin32.
I could see it working to have a CREDENTIALW* Pointer
property on the generated SafeHandle class, but I do see how this could be worse for discoverability. It would technically pass the all hurdles you mentioned though, since you can do anything with it that you can do with the current out CREDENTIAL*
pointer you get.
If you wanted to make things safer, the friendly overloads could take the safe handle instead of in CREDENTIALW
/ref CREDENTIALW
/CREDENTIALW*
parameters. The friendly overload would do DangerousAddRef etc and pass safeHandle.Pointer
to the p/invoke method.
from cswin32.
Related Issues (20)
- `ShellExecuteEx` is not generated HOT 1
- How to Generate MOD_CONTROL in RegisterHotKey function (winuser.h) HOT 1
- IPolicyConfig and PolicyConfigClient not created HOT 5
- GetApplicationUserModelId - wrong function signature HOT 1
- Pointers to native classes should _not_ be dereferenced by C# HOT 1
- Allow turning off "friendly" P/Invoke overloads
- GdiPlus Color struct is generating with statics as fields
- Source generated files are added to compilation with SHA1 algorithm HOT 5
- Failed to open generated code in Visual Studio Code HOT 1
- IAudioSessionManager2::GetSessionEnumerator missing parameter HOT 4
- Bug: CONNECT_UPDATE_PROFILE cannot be found HOT 3
- CredUIPromptForCredentials should not emit `ref` on `ref Span<char>` parameter
- Access violation writing location when calling DirectX APIs. HOT 1
- Use System.Runtime.InteropServices.ComTypes.IStream instead of generating the interface HOT 1
- Enable generating IID_IDispatch constant
- Accessing property IShellFolderViewDual.Application causes InvalidOleVariantTypeException "Specified OLE variant is invalid" HOT 1
- SC_HANDLE should be a managed SafeHandle derived type
- No consistent definitions in some Com interface methods HOT 4
- Generate overload that sets `dwLength`? HOT 2
- Not all types are from authif.h are generated as expected
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cswin32.