Comments (5)
RyanDawkins
commented on May 18, 2024
Looks like this can be closed.
from botbuilder-dotnet.
cleemullins
commented on May 18, 2024
Not quite yet. There is 1 left. :)
…________________________________
From: Ryan Dawkins <[email protected]>
Sent: Tuesday, February 20, 2018 9:00:16 PM
To: Microsoft/botbuilder-dotnet
Cc: Chris Mullins; Assign
Subject: Re: [Microsoft/botbuilder-dotnet] HTTPClient(s) in the Connector should be pooled (#60)
Looks like this can be closed.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fbotbuilder-dotnet%2Fissues%2F60%23issuecomment-367214087&data=04%7C01%7Ccmullins%40microsoft.com%7C8c1bc524c2b14c24ee2608d578e8009a%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636547860200252291%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwifQ%3D%3D%7C-1&sdata=%2B4Sx9IAWpJckGPi4WgWUoq6iE74g72YLlzBQBhhFXEg%3D&reserved=0>, or mute the thread<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABHICXjSK2IuVxgLyI_ir_snGGNevFCTks5tW6LggaJpZM4R51D6&data=04%7C01%7Ccmullins%40microsoft.com%7C8c1bc524c2b14c24ee2608d578e8009a%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636547860200252291%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwifQ%3D%3D%7C-1&sdata=gqZJo1WDRMEk%2FXsaOmhK9n%2BuRhwAOgl3O3ImKTH7QsU%3D&reserved=0>.
from botbuilder-dotnet.
cleemullins
commented on May 18, 2024
The remaining one to fix is the ConnectorClient. It's called in few places.
@EricDahlvang is looking into this now. It's complex because it's down in auto-generated code and the patterns for fixing it are non-obvious.
from botbuilder-dotnet.
EricDahlvang
commented on May 18, 2024
In August, a constructor was introduced to ServiceClient that allowed consuming code to specify if HttpClient should be disposed https://github.com/Azure/azure-sdk-for-net/pull/3547/files . A method was also added that ensures ProductInfoHeaderValues are not added to UserAgent twice. However, this throws exceptions when a ProductInfoHeaderValue is provided that does not have a Product (i.e. constructed with comment only). Also, the ServiceClient itself adds a ProductInfoHeaderValue every time. These things make the HttpClient constructor on ServiceClient an invalid option for re-using a static HttpClient . ( filed this issue: Azure/azure-sdk-for-net#4086 and this PR Azure/azure-sdk-for-net#4095 )
These things considered, the only viable option at this time is something like what @tomlm submitted here: https://github.com/Microsoft/BotBuilder/blob/d09bcc9c46e2a16d9d523f4209387fd0aaa68b29/CSharp/Library/Microsoft.Bot.Connector.Shared/ConnectorClientEx.cs
from botbuilder-dotnet.
cleemullins
commented on May 18, 2024
With Tom's most recent changes, #186, this is now done.
@EricDahlvang
from botbuilder-dotnet.
Related Issues (20)
- File attachments are not sent in Teams team chat threads HOT 2
- MicrosoftGovernmentAppCredentials's OAuthEndpoint should include TenantId when set HOT 1
- Failed to continue dialog. A dialog with id xxxx could not be found. HOT 4
- USGov OAuthEndpoint while using SingleTenant
- feat: Ase Channel Validation
- Get a title of a message from TurnContext class. HOT 2
- StreamingSession json serializer bug (Lost property ContentType).
- BuiltinBotFrameworkAuthentication.GetAppId try to check (appid/azp) before (aud)
- Add support for isVisible property in SharePoint Bot Adaptive Card Extension
- Port [#4582] UserAssignedIdentity(WorkloadIdentity) auth fails with 'scope https://api.botframework.com is not valid' HOT 1
- Failed to invoke task module from hero card - Malformed AAD token or required field not found HOT 1
- Request to Move `ConfigurationBotFrameworkAuthentication` from Microsoft.Bot.Builder.Integration.AspNet.Core to Microsoft.Bot.Connector HOT 2
- .Net 8 HOT 3
- Issue with Multiple Messages in Slack Bot Channel after Updating to Microsoft Bot Builder SDK Version 4.22.0 HOT 9
- Microsoft.Bot.Builder.AI.QnA library -> migration path from QnAMakerRecognizer to Custom Question Answering?
- Dialog State Storage Issue in Bot Builder Composer: Impact on Automation and Conversations
- The ShowTypingMiddleware throws System.ObjectDisposedException when an exception occurs in the bot HOT 5
- Waterfall steps are being called out of order
- Update to version 3 of the Azure Cosmos DB .NET SDK
- Posting back response to bot - Access has been blocked by Conditional Access policies. The access policy does not allow token issuance. HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from botbuilder-dotnet.