Comments (8)
cleemullins
commented on May 18, 2024
I have most of these tagged for looking at. Thanks for driving home that I need to fix them sooner rather than later.
+1
from botbuilder-dotnet.
RyanDawkins
commented on May 18, 2024
I've made a start at this and for #107 on my fork.
I've started on this for the QnAMaker and the Translator class.
I have implemented the changes for the Translator and the QnA maker and I'm in the process of testing.
from botbuilder-dotnet.
cleemullins
commented on May 18, 2024
Thanks Ryan! I was actually just reading about best practices around HttpClient and will look forward to seeing your PR.
from botbuilder-dotnet.
RyanDawkins
commented on May 18, 2024
Just tested the QnA version! I'm about to setup Luis to make sure that is working too.
from botbuilder-dotnet.
cleemullins
commented on May 18, 2024
Multiple smaller PRs are fine with me. No need for one giant one...
…________________________________
From: Ryan Dawkins <[email protected]>
Sent: Wednesday, February 14, 2018 10:37:39 PM
To: Microsoft/botbuilder-dotnet
Cc: Chris Mullins; Assign
Subject: Re: [Microsoft/botbuilder-dotnet] HttpClient disposal anti-pattern (#106)
Just tested the QnA version! I'm about to setup Luis to make sure that is working too.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fbotbuilder-dotnet%2Fissues%2F106%23issuecomment-365838297&data=04%7C01%7Ccmullins%40microsoft.com%7C74e98674b49e4735798a08d5743e9bcd%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636542734610713772%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwifQ%3D%3D%7C-1&sdata=bnDmyHMJEv4NZH3kc6Vwl%2F%2FdQZhfYCecWnYdZBWoHWM%3D&reserved=0>, or mute the thread<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABHICeQv1pt56vyxbvmMKX44jBtNmJHGks5tU9CzgaJpZM4SFw1D&data=04%7C01%7Ccmullins%40microsoft.com%7C74e98674b49e4735798a08d5743e9bcd%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636542734610713772%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwifQ%3D%3D%7C-1&sdata=hHGXdFdyVjiYdEcZIikidDYmDLFIdO752Nf4ssasKEg%3D&reserved=0>.
from botbuilder-dotnet.
RyanDawkins
commented on May 18, 2024
Here you go!
#122
from botbuilder-dotnet.
cleemullins
commented on May 18, 2024
Pending PR for the remaining places this code existed: #133
from botbuilder-dotnet.
cleemullins
commented on May 18, 2024
Fixed. Thanks.
from botbuilder-dotnet.
Related Issues (20)
- The ShowTypingMiddleware throws System.ObjectDisposedException when an exception occurs in the bot HOT 5
- Waterfall steps are being called out of order
- Update to version 3 of the Azure Cosmos DB .NET SDK
- Posting back response to bot - Access has been blocked by Conditional Access policies. The access policy does not allow token issuance. HOT 4
- And the Useless Constructor Overload Award goes to... HOT 1
- Token Service Gives a 500 Service Error When Exchanging Token
- Wrong results when using OAuthPrompt from group or channel
- Bot returns an error when using Regex validation in adaptive cards HOT 6
- Migrate to System.Text.Json - remove newtonsoft HOT 1
- CosmosDBKeyEscape.TruncateKeyIfNeeded return different value after compiled
- The Bot Framework SDK for C# does not return a value in the Activity.LocalTimezone property when using Copilot in Microsoft Teams HOT 2
- File Attachment gives error in private endpoint enabled bot
- Adaptive card sent by bot builder framework only shows "Sent a card" as the message, in iPhone
- Teams V2 messaging extension started from commandbox has no context (URL placeholder are not replaced with values)
- When using skills with user assigned managed identity , the msi endpoint fails with a 500 HOT 22
- Provide Logging around config issues with auth HOT 3
- Convert to new CodeQL suppression syntax
- Add SingleTenant/MSI Issuer to ValidTokenIssuers for Skill samples
- How to migrate from Bot SDK 4.3 to Azure Bot Service HOT 3
- Add M365 channel id's to Microsoft.Bot.Connector.Channels.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from botbuilder-dotnet.