Giter Club home page Giter Club logo

Comments (6)

JohnSchmeichel avatar JohnSchmeichel commented on May 24, 2024 1

maybe stale?

from artifacts-credprovider.

JohnSchmeichel avatar JohnSchmeichel commented on May 24, 2024

As for a fix here, ideally the credential provider can be installed as ContainerUser without elevating, but there are a few unfortunate limitations here:

  1. The install script uses the TEMP env var (and .NET methods based off that) to create temporary files, but ContainerUser doesn't have any access to delete the temp files it creates (hence the icacls workaround to resolve this, granting read/delete permissions).
  2. On Nano Server there just isn't a good scratch location for temp files, so creating and cleaning up temp files needs to be done in the docker build itself.

The core problem imho is that these script-based install mechanisms leave a lot to be desired and run into these platform limitations both on capability and differences. Using a mechanism like the proposed NuGet/Home#12567 would make all of these problems obsolete and allow the credential provider install to work cross-platform.

In the near term however, I'd propose the following changes to keep the spirit of the ContainerUser permission model (and the docker sample's goal of building within the container as a low-privileged account in a 2-phase build for isolation):

  1. Update the installcredprovider.ps1 script to allow an install path to be specified, falling back to TEMP if none is specified.
  2. Update the docker sample to install into a custom temp folder, such that it has full permissions to clean up after install.

from artifacts-credprovider.

JohnSchmeichel avatar JohnSchmeichel commented on May 24, 2024

Able to do this in the sample itself with dotnet/dotnet-docker#4828

from artifacts-credprovider.

github-actions avatar github-actions commented on May 24, 2024

This issue has had no activity in 90 days. Please comment if it is not actually stale.

from artifacts-credprovider.

embetten avatar embetten commented on May 24, 2024

not stale.

from artifacts-credprovider.

github-actions avatar github-actions commented on May 24, 2024

This issue has had no activity in 90 days. Please comment if it is not actually stale.

from artifacts-credprovider.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.