Allow connectionString to be overridden multiple times without restarting the AppInsights Agent about applicationinsights-java HOT 5 OPEN

Fantastic, thanks @jeanbisutti.

Will provide feedback early next week.

from applicationinsights-java.

@slavik112211 You can download here a SNAPSHOT version with the connection string check removed. Could you please try it?

from applicationinsights-java.

@jeanbisutti,

confirming that the provided applicationinsights-agent-3.5-SNAPSHOT.jar correctly sets the connectionString multiple times throught the lifecycle of the application using:
com.microsoft.applicationinsights.connectionstring.ConnectionString.configure(connectionString);
Tested using telemetryClient.trackMetric(metric), and confirm that customMetrics end up in different AppInsights endpoints.

Please proceed with merging your change into Production version.

Please note, our app is not using the agent jar directly (i.e. applicationinsights-agent-3.5-SNAPSHOT.jar), but rather uses <artifactId>applicationinsights-runtime-attach</artifactId>, and thus the new agent would need to be incorporated into the new applicationinsights-runtime-attach Maven package.

from applicationinsights-java.

@slavik112211 Thanks for testing. The fix will work both with -javaagent and with the applicationinsights-runtime-attach dependency.

from applicationinsights-java.

@jeanbisutti With a similar need, with the 2.x SDK, we were able to create different TelemetryClient instances that sent data to different application insight resources by setting the respective instrumentation key.

@Configuration
public class TelemetryClientConfiguration {
    @Value("${azure.application-insights.vendorcomm-instrumentation-key}")
    private String vendorCommAppInsightsKey;
  
    @Value("${azure.application-insights.cps-app-insights-instrumentation-key}")
    private String appInsightsKey;

    @Bean("vendorCommTelemetryClient")
    public TelemetryClient vendorCommTelemetryClient() {
        TelemetryClient telemetryClient = new TelemetryClient();
        telemetryClient.getContext().setInstrumentationKey(vendorCommAppInsightsKey);
        return telemetryClient;
    }
  
    @Bean("appInsightsTelemetryClient")
    public TelemetryClient appInsightsTelemetryClient() {
        TelemetryClient telemetryClient = new TelemetryClient();
        telemetryClient.getContext().setInstrumentationKey(appInsightsKey);
        return telemetryClient;
    }
}

However, when moving to the 3.x SDK, it does not appear that we have same capability. I was hoping that something like this would have worked...

@Configuration
public class TelemetryClientConfiguration {
    @Value("${azure.application-insights.connection-string}")
    private String connectionString;

    @Value("${azure.application-insights.vendorcomm-connection-string}")
    private String vendorCommConnectionString;

    @Primary
    @Bean("appInsightsTelemetryClient")
    TelemetryClient telemetryClient() {
        TelemetryClient telemetryClient = new TelemetryClient();
        telemetryClient.getContext().setConnectionString(connectionString);
        return telemetryClient;
    }

    @Bean("vendorCommTelemetryClient")
    TelemetryClient vendorCommTelemetryClient() {
        TelemetryClient telemetryClient = new TelemetryClient();
        telemetryClient.getContext().setConnectionString(vendorCommConnectionString);
        return telemetryClient;
    }
}

...but unfortunately all of the telemetry is being sent to the application insight resource that was set with this line of code...

com.microsoft.applicationinsights.connectionstring.ConnectionString.configure(connectionString);

Is there a way to accomplish what we're attempting to do with having multiple TelemetryClients with different connection strings in the same application?

Thank you for your time

from applicationinsights-java.