Comments (3)
RyanCavanaugh
commented on April 20, 2024
Per CR comments, the fix breaks this (bad) code from 1.0:
class C { get f() { return; } }from typescript.
DanielRosenwasser
commented on April 20, 2024
To be clear, the old compiler was okay with
function foo(): number {
return;
}as well.
Well, I wouldn't say that fixing this bug is a breaking change; rather, I misunderstood the issue with this bug in Pull Request #147. I thought that we should be looking for return expressions rather than statements; however, I think it's worth asking if that's the correct behavior.
from typescript.
DanielRosenwasser
commented on April 20, 2024
I've opened up #162 to discuss this.
from typescript.
Related Issues (20)
- Duplicate diagnostics HOT 2
- `const enum` references in the body of nodes with grammar errors are not inlined
- `static` methods can access `this.constructor` without complaints and compiles correctly, but a runtime error shows up HOT 12
- ModuleResolution Node16/NodeNext fails without extension starting on 5.5.0-dev.20240413 HOT 5
- Assigning a @type to an async function emits an error HOT 1
- Type predicate covariant comparison is unsound HOT 1
- Assignability to `asserts` type predicate is not checked HOT 1
- Constrained type param with `keyof` seems to have inconsistent behavior HOT 2
- Why generics are not working as expected? HOT 3
- Type guarding against BigInt using typeof not working - but using instanceof works, even though that javascript code will not work HOT 1
- Type check and Object key completion on overloaded functions with generic types defined in a class are incorrect
- Computed Void is an Expected Param where Void is not HOT 4
- Narrowing empty string or false in generic misbehaves HOT 1
- `tsc` compile `proposal-explicit-resource-management` different from `babel` and `swc` HOT 1
- After enabling noUncheckedIndexedAccess, using ++ on a default undefined does not trigger an error message. HOT 3
- C++-style `const` modifier on class members HOT 1
- Package Import is not working from neither way "CommonJS" or "Module" HOT 4
- Type guard for child not transitive parent object HOT 2
- Error when compiled JavaScript initializes static properties in a class with a hard private method (`#`) that references a static property
- The ?: inference failed; no selection was made between ifTrue and ifFalse. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from typescript.