Comments (11)
The actual behavior here matches the spec. It appears to be by design.
from typescript.
Another interesting example where we don't error, but probably should:
var v: { [s: string]: string} = {
p: 3, // Expect an error here
q: null
}
This is a result of best common type losing information, and the nontransitivity of assignability.
from typescript.
What's the action here? If we're aligned to spec, shouldn't this just be closed as by design?
from typescript.
As I recall from discussion, the spec needs to be updated to align with the current behavior. Specifically, I think section 3.8.1 needs to not pull in call/construct/index signatures for the augmented types.
And it is a breaking change.
from typescript.
I'm confused. You mention earlier that the "actual behavior here matches the spec. It appears to be by design." If so, is there a spec change?
from typescript.
Yeah my previous comments were wrong because I misunderstood what was going on. Ignore those. It needs a spec change per my recent comment.
from typescript.
Before we make this change, please confirm that the change does not impact real world code before we make the spec change.
from typescript.
Reopening this because the validation on real world code was not done yet.
from typescript.
Doesn't break any real world code we know of.
from typescript.
Is this fixed, or by design?
from typescript.
Fixed, in that it is a change from the old compiler. Spec has been updated to reflect behavior of the new compiler.
from typescript.
Related Issues (20)
- Function lacks ending return statement and return type does not include 'undefined' HOT 6
- Inference of recursive arrow function's return type is any HOT 2
- [NewErrors] 5.5.0-dev.20240405 vs 5.4.4 HOT 25
- [ServerErrors][TypeScript] 5.5.0-dev.20240405 HOT 17
- [ServerErrors][JavaScript] 5.5.0-dev.20240405 HOT 11
- Methods with generic properties in a class cannot be assigned to unknown. HOT 1
- Is there a good way to accurately identify the cause of an error in a union type? HOT 8
- Too wide diagnostic with array spread HOT 1
- Add persian translation to docs HOT 1
- No error when accessing setter-only properties HOT 2
- "typescript.preferences.importModuleSpecifier": "project-relative" is not as intended HOT 8
- Intellisense import suggestions in JS/TS files do not work HOT 4
- Preserve `set`-only accessors in declaration emit
- NoInfer introduced in 5.4 is undocumented HOT 5
- Compile does not produce an error when parameters in overriding class method in child class have narrower type than the parameters of this method in the parent class HOT 4
- Update getTimezoneOffset JSDoc for clarity HOT 1
- ts80007 is incorrect at times? HOT 2
- Problems with __esModule marker in JS/TS mixed node16 environemnt HOT 3
- Error reported only in `node_modules` directory HOT 3
- Incorrect Chinese Translation for 'initializer' and Incorrect Use of Chinese Quotation Marks
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from typescript.