Feature Request: Service Discovery across multiple namespaces about micronaut-kubernetes HOT 9 CLOSED

sure sure, that was my idea, I meant mandatory in case you want to discovery service from other then app configured namespace.

from micronaut-kubernetes.

How would using # as separator propagate to the client configuration? Lets say you would like to set the read timeout for the client

micronaut.http.services.my-ns#my-service.read-timeout=PT5S

Thinking that # is considered a comment in .yaml and .properties files.

from micronaut-kubernetes.

@jaksah we spoke about this with @alvarosanchez and at this moment we agreed that the namespace will be part of configuration like:

kubernetes:
  client:
    discovery:
      services:
        my-service:
          namespace: my-ns

from micronaut-kubernetes.

It shouldn't be too difficult to change https://github.com/micronaut-projects/micronaut-kubernetes/blob/master/kubernetes-discovery-client/src/main/java/io/micronaut/kubernetes/discovery/KubernetesDiscoveryClient.java#L84 to search in all namespaces. PRs welcomed

from micronaut-kubernetes.

@alvarosanchez imho this could potentially end up in lot of 403s if micronaut service account is not authorised to get Services. But by default it could do the job, but I would extend it with namespace filtering, similarly like it's for service filtering. Anyway, in my opinion we should also distinguish service namespaces in the annotation liek @Client('<namespace>.<service-name>').

from micronaut-kubernetes.

The 403s can also happen even for the default namespace. I expect someone wanting to call services across namespaces to understand it needs permissions. Hence, I wrote https://micronaut-projects.github.io/micronaut-kubernetes/latest/guide/#_kubernetes_api_authentication. It should be a matter of explaining it there.

Regarding namespace filtering, I see it problematic. The Kubernetes API lets you search either within a concrete namespace, or all. If you were to have includes/excludes, you would need to make several API calls to retrieve the list of namespaces first, then for each retrieve the list of services. And the service discovery is refreshed every 30 seconds.

A better option would be specifying the namespace in the annotation as you suggested (I'd rather avoid using a dot as separator, so maybe @Client("<namespace>#<service-name>")). That way you only search on that namespace.

from micronaut-kubernetes.

Yeah, if we would make it like mandatory to define the namespace in the annotation to distinguish the target namespace, then the filtering is useless. 👍

from micronaut-kubernetes.

It doesn't need to be mandatory though. One could have @Client("my-service") (which would target the default namespace) and @Client("my-ns#my-service")

from micronaut-kubernetes.

Closing addressed in #191

from micronaut-kubernetes.