GCP Tracing issues on latest version about micronaut-kubernetes HOT 7 CLOSED

@pgressa Apologies on the long delay, I just tried that with the latest 2.1.1 and all seems to be working fine, updated the project and with kubernetes-discovery 2.0.0 and tracing enabled and it all seems to be fine, thank you for looking into this :)

from micronaut-kubernetes.

#Update:
I just found that when micronaut-kubernetes-discovery-client is removed from the classopath the problem is gone. Maybe an issue with that project?

from micronaut-kubernetes.

hi @viniciusccarvalho

@pgressa is going to be looking at this issue soon, this is still valid with 2.0.1 as far as you know?

from micronaut-kubernetes.

hi @viniciusccarvalho, I reproduced the error but I wasn't able to reproduce the correct behaviour when micronaut-kubernetes-discovery-client was removed, so please double check https://github.com/pgressa/micronaut-kubernetes-161 whether the state of the project is same like in your project.

Anyway, those errors can be addressed by appending dependecies, but both solutions (zipkin/jaeger) won't be needed:

implementation("io.jaegertracing:jaeger-thrift")
implementation("com.netflix.hystrix:hystrix-core")
implementation('io.zipkin.brave:brave-instrumentation-http')

These dependencies are basically part of micronaut tracing module the micronaut-gcp-tracing module uses, where these deps are declared -> https://github.com/micronaut-projects/micronaut-core/blob/master/tracing/build.gradle#L11 , I'll try to figure out what the formulation should mean:

// the following are Tracing implementations and instrumentations which
// are optionally loaded and not required

as due to compileOnly the dependencies won't get to pom.xml.

from micronaut-kubernetes.

@viniciusccarvalho could you please review https://github.com/pgressa/micronaut-kubernetes-161 so I can reproduce the issue? Thanks!

from micronaut-kubernetes.

Thank you for looking into this. I'll check tonight with my project and will reply here. Cheers

from micronaut-kubernetes.

@viniciusccarvalho any updates or can I close this one?

from micronaut-kubernetes.