dash to dock multi monitor about dash-to-dock HOT 108 OPEN

Thanks all for the offer of support. Unfortunately, the reason I don't have a secondary monitor is really lack of space for it rather than economical affordability... However, I can occasionally hook up my laptop to a tv, it's just not the most comfortable developing location, especially for extensive testing and bug hunting.

That said, I intend now to work on this feature and try to merge it in the next release, time permitting.

from dash-to-dock.

I'm looking forward to this, we'll definitely need it now Unity is dead.

from dash-to-dock.

@micheleg In Ubuntu, the dock is (by default) visible on all monitors. The icons are the same in all docks, but there is a distinct indicator (a triangle) indicating the application is running on another monitor. So, on the monitor the app is running, you have a circle. On the others, a triangle. AFAIK there is no way to configure it to only show the icons of the current monitor, because anyway the pinned applications always appear, I don't think it makes much sense.
I don't run Unity since a long time, but that is how it works.

from dash-to-dock.

Hi all:
I rebased the tree I was working on [[https://github.com/franglais125/dash-to-dock/tree/multi_monitor] to update it against @micheleg's master.

As far as I can tell, the code works quite well (tested on Gnome 3.20):

• I haven't had crashes or errors
• All features seem to work properly
• I can toggle the multi-monitor feature, and it seems to work as expected

What I would really need is some testing, as I can't cover all use-cases and combination of features. I have sent some pull requests, but this one is a bit bigger and more intrusive.
I'd feel more comfortable if somebody could test this branch and send me feedback.

from dash-to-dock.

@jonnjonzzn

You simply need to check the "Show on all monitors." check box :)

from dash-to-dock.

@micheleg you bring up some nice questions!

Structure

As you said, the patches I propose can feel a bit like a hack in the sense that I tried not to be disruptive, while keeping a sane implementation. However, I did think of a consistent structure:

• Just like the dock contains a dash, which contains AppIcons, what I introduce is a dockManager, which contains docks, which then contain the necessary objects.
• Although there are 6 patches this is the main commit to look at: [bffca45].
• The other commits are secondary (but necessary to avoid crashes). For instance, we need proper signal handling, as docks can now be dynamically created/deleted. Since I'm moving a lot of signals to a signalHandler, the changeset might look big, but it's actually a large copy-paste, with appropriate brackets.

What kind of multimonitor are we looking for?

For now, the multi-monitor option simply duplicates the dock on all screens. My idea was first to get the basic support in, and then introduce subsequent smaller features.

• For instance, it would be nice to have a "screen isolation" option, just like workspace isolation.
• I'm not aware of how the dock behaves on MacOS. A dock simply appears on the screen where the mouse is active?
• As for adding more settings (dependent on workspace settings for instance), I think this is not difficult to add within the dockManager class. It's only a matter of adapting _createDocks() and _deleteDocks().

PR?

At this point I think it would be simply better to start a PR and discuss structure/commits over there.

from dash-to-dock.

I'll try to use it tomorrow and I'll tell you how it went

from dash-to-dock.

I'm testing @franglais125's modifications on Fedora 25 and it's working beautifully. It works after disconnecting and reconnecting the external display. I'm using intelligent autohide and they both behave independently as you'd expect. Looks good!

from dash-to-dock.

Hi all, I just updated (rebased) the branch to follow the latest developments, and more specifically to include a nice fix for Wayland: thanks Michele!

From what I gathered, the feedback has been rather positive about how the multi-monitor dash is working. However, if anyone else willing to test it, please let me know if you find problems.

https://github.com/franglais125/dash-to-dock/tree/multi_monitor

from dash-to-dock.

I have been waiting for a long time to see this feature integrated into the master. I use 3 monitors at work, and at home, sometimes I use 1 monitor along with the TV. And I've never had a problem using this @franglais125 branch. Using Manjaro (4.9.15-1-MANJARO) GNOME Shell 3.22.3.

from dash-to-dock.

@micheleg, you will need an extra monitor when this feature is merged.

I recommend at least buying a cheap monitor $ 119
https://goo.gl/scEvvu

I can contribute $25, if we can get some more donors I think it's worth it for everyone.
https://www.bountysource.com/issues/1218983-dash-to-dock-multi-monitor

What do you think? If you agree, I can make the donation.

from dash-to-dock.

@gabrielmoreira I was going to suggest something like this too. I can chip in as well, if @micheleg is interested!

from dash-to-dock.

@uloco if you install from source, I assume you mean running make install. You need to checkout the multi_monitor branch to get the new feature. Something like:

git clone https://github.com/micheleg/dash-to-dock
cd dash-to-dock/
git checkout multi_monitor
make && make install

A word of caution: it's an experimental branch, and might have a few problems still, hence why it isn't merged yet.

from dash-to-dock.

This has been merged into master. Please provide any useful feedback, in terms of bugs and possible improvements.

from dash-to-dock.

It will be included in the next release. I'm waiting for some feedback but I should upload a new release reasonably soon (~1 week time).

from dash-to-dock.

Hi,

Do you mean multiple dock, one on each monitor with only the applications
running on that monitor?

from dash-to-dock.

Yes.

On 22 nov. 2012, at 19:27, Michele [email protected] wrote:

Hi,

Do you mean multiple dock, one on each monitor with only the applications
running on that monitor?
—
Reply to this email directly or view it on GitHub.

from dash-to-dock.

I don't think I'm going to implement something like this in the near future, for two main reasons:

1.) It would require quite a lot of work and I'm not sure I have time to do it now. Moreover not having a multiple monitor configuration slows down a lot the development and testing of such feature and stops me from starting to experiment with it in my spare time.
2.) I think it's not the way multiple monitors are meant in gnome-shell but I'm not sure about this. If I remember correctly the secondary monitor is usually just a static workspace. I've tried to be as consistent as possible with the default gnome-shell behaviour, and so for instance I decided to keep thinking of the dock as a part of the overview.

Anyhow I'm not dropping the idea completely.

from dash-to-dock.

I really like the multi-dock that Ubuntu offers, it really helps reducing mouse movement and allows to locate windows at a glance since clicking twice on an icon show all the applications on the screen.
In a triple monitor setup I have 2 active monitor and a static one. On a single monitor, however, I use workspaces.

from dash-to-dock.

+1 to this idea. I'd like to see this coming somewhere in near future :)

from dash-to-dock.

@ticpu: I'm too lazy to try to install ubuntu... how does ubuntu handle the multimonitor thing: is the dock the same on all monitors or are them multiple docks restricted to the apps of each specific screen?

from dash-to-dock.

Thanks for the information.

from dash-to-dock.

I'd very much like to have this feature too, that's pretty much the only thing I regret from Unity

from dash-to-dock.

+1 for this. It would really boost productivity with multi monitor setups.

from dash-to-dock.

+1

from dash-to-dock.

+1

from dash-to-dock.

👍

from dash-to-dock.

I'd love this to be implemented as well. I don't care for only showing the windows open for each window, I'd rather just have the dock duplicated on each monitor. But either way, it would be very great

from dash-to-dock.

I'd be happy to contribute if I'll get some guidance on how to start implementing it.
I never worked on gnome extensions so I don't have the right knowledge.

from dash-to-dock.

@ItamarShDev : thanks for your interest in helping the development of dash-to-dock. A already said, there is no real blocking thing for having duplicated docks. Indeed, I can run two independent docks by simply duplicating the extension with a different name with very minor issues.

With independent settings it's then easy to move one of the dock in the secondary monitor.

So it's mainly a matter of organizing the code in order to allow the instantiations of two dash objects.

If you have a look at the code, in extension.js the docking.DockedDash object (https://github.com/micheleg/dash-to-dock/blob/master/docking.js#L184) is created. A dirty approach would be to duplicate it at this level, creating another one and somehow force its settings to show the dock on the secondary monitor. This would be basically as duplicating the whole extension, duplicating also the code dealing with intellihide and the various shell tweaks which should instead be kept in common. You don't need a particular understanding of Gnome Shell innards, but only of Javascript, to get the idea of how rework the code. I see two options:

1. The DockedDash class instantiates multiple dash objects and deal with them.
2. The DockedDash class is split into a component dealing with the single dock placement and logic, and one dealing with settings, overview tweaking, etc.

Are you willing to look into this? If so I can provide guidance once you get an overview of the code.

from dash-to-dock.

@micheleg sure i am willing
I have already looked at the code, will be happy to help.
will give it another look this evening or tomorrow's
Will be happy to more guidance if needed
Thanks for the info

from dash-to-dock.

I went with the "easy approach" and renamed the extension to a new one with different settings.

rm -rf ~/.local/share/gnome-shell/extensions/[email protected]
cp -R ~/.local/share/gnome-shell/extensions/[email protected] ~/.local/share/gnome-shell/extensions/[email protected]
mv ~/.local/share/gnome-shell/extensions/[email protected]/schemas/org.gnome.shell.extensions.dash-to-dock.gschema.xml ~/.local/share/gnome-shell/extensions/[email protected]/schemas/org.gnome.shell.extensions.dash-to-multiple.gschema.xml
sed -i 's/Dash to Dock/Dash to Multiple/g' ~/.local/share/gnome-shell/extensions/[email protected]/metadata.json
sed -i 's/dash-to-dock/dash-to-multiple/g' ~/.local/share/gnome-shell/extensions/[email protected]/metadata.json ~/.local/share/gnome-shell/extensions/[email protected]/*.js ~/.local/share/gnome-shell/extensions/[email protected]/schemas/org.gnome.shell.extensions.dash-to-multiple.gschema.xml
rm ~/.local/share/gnome-shell/extensions/[email protected]/schemas/gschemas.compiled
glib-compile-schemas ~/.local/share/gnome-shell/extensions/[email protected]/schemas/

Then, hit alt+f2 and execute r to reload gnome-shell. You can now activate and configure your independent copy with the tweak tool.

from dash-to-dock.

Hi, I'm not planning on working on this in the near future, but if someone wants to look at it, I created a branch with minimal (and hacky) support for 2 monitors.
https://github.com/franglais125/dash-to-dock/tree/multi_monitor

I'm essentially duplicating the DockedDash object, but I'm forcing two of them on 2 monitors, so you need at least 2 monitors to run it properly!

Todo:

• Create appropriate options in the Setting.ui
• Manage the creation/deletion of new DockedDash objects properly
• Manage some signals and keys that are repeated (workspace isolation and hotkeys for instance)

Just to make it clear, this is not a correct implementation; the single patch that matters [4abfb6e] shows what object to duplicate, and basic monitor handling.

I tested it on 2 monitors and it "works", not sure if it will crash eventually, so be careful if you install it :).

Cheers

from dash-to-dock.

Well, I ended up working on it, as it wasn't as much work as I thought, at least to get it to work minimally. The 3rd point still need to be checked:

• Manage some signals and keys that are repeated (workspace isolation and hotkeys for instance)

I just updated the tree [https://github.com/franglais125/dash-to-dock/tree/multi_monitor].
If anyone wants to give it a try, it seems to work reasonably well on Gnome 3.20. I won't be doing a PR until some other PRs are resolved though.

from dash-to-dock.

I'm currently testing the extension on Gnome 3.18 on Ubuntu Xenial, no problem whatsoever. Currently set options are extend dock and isolate workspace.

from dash-to-dock.

I think I encountered a crash while unlocking my screen. This is the first crash I had with gnome-shell in quite a while. I still have the process open in gdb if needed.

https://gist.github.com/ticpu/686b1d4cd8c3caf4b42b02e84a95f2cc

from dash-to-dock.

@ticpu any new problems to report? Or did the fix I included work well so far? And thanks for your feedback so far.

To all: I updated the multi-monitor branch (https://github.com/franglais125/dash-to-dock/tree/multi_monitor) after the release of v54. So if anyone else is willing to test it, please let me know how it goes!

from dash-to-dock.

I've been using it daily ever since the last release without any updates. No crash yet.

from dash-to-dock.

@ticpu thanks!

@bishiboosh I forgot to mention that the multi-monitor tree only works for Gnome Shell 3.18, 3.20 and 3.22

from dash-to-dock.

It works.

from dash-to-dock.

@micheleg Is it a good time to start a PR for this?

Perhaps there are other issues/PRs you want to handle first!

from dash-to-dock.

I'd like to merge the hotkeys branch first. As usual I'm a bit scared of introducing big changes until I become confident about it. I need to find the time to review it. How much do you like your current implementation?

from dash-to-dock.

Well, I'm scared of introducing too many changes too! I'm asking now as there seems to be at least a few people using it (without bad reports).

Super summary: essentially the way it works is that there is a "dockManager" that creates and deletes docks whenever the monitors change.

This is what I have to say (briefly) about the 7 commits:

• I tested the patches exhaustively, so I know that it won't crash or block other features (and this is why I was asking for other people to test it), of course bugs are always possible.
• The first 2 commits are only preparatory, essentially properly connecting/disconnecting signals (due to the fact that now we delete docks).
• The next 3 commits are the core implementation: define the "dockManager" and how it interacts. Mainly what I have to say about this is that it is "AN" implementation, and not "THE" only one possible.
• The last 2 patches are just to make things look nicer.

I can wait for you to review/accept/reject the hotkeys implementation, and then bother again with this when you are done.
Or I can send you this now/soon (with a better description), and just wait for you to find the time to review it. As you prefer!

from dash-to-dock.

+1 for this feature

from dash-to-dock.

+1 for this feature

from dash-to-dock.

For anyone interested, I rebased the multi-monitor branch (https://github.com/franglais125/dash-to-dock/tree/multi_monitor), so that a merge is still easily feasible.

from dash-to-dock.

@franglais125 do you have this feature implemented for 3.14? I have a single monitor only at home but I'd like to run it at work where I have two screens.

from dash-to-dock.

@micheleg I just prepared a branch for 3.14. I simply had to cherry-pick a few commits from my gnome-3.14-custom branch.

Here it is: https://github.com/franglais125/dash-to-dock/commits/gnome-3.14-multi_monitor

By the way, it contains the hotkeys as well (first 2 commits).

Here is a comparison:
https://github.com/micheleg/dash-to-dock/compare/gnome-3.14...franglais125:gnome-3.14-multi_monitor?expand=1

from dash-to-dock.

Thanks,

I'll give it a try next week.

from dash-to-dock.

@micheleg did you get a chance to test it? :)

from dash-to-dock.

@franglais125 I installed the multi monitor branch from here. Up until now everything feels as it should, the only thing i noticed is that when i press application button of dock on the second monitor it actually opens it on the "primary". Nice effort :)

from dash-to-dock.

@pkoutsovasilis this is gnome related imho
as the apps and overview always display in the main monitor.
I am using two monitors for awhile on gnome and i dont recall any extension that manipulates this behavior.

but, maybe im mistaken

from dash-to-dock.

@micheleg sorry i wasn't here, i caught up in my work (new work, new programming language)
and weren't able to find me some time to work on it to the fullest :(

from dash-to-dock.

@pkoutsovasilis thanks for the feedback! I noticed this too, but I am not sure that adding the option to open the overview on the secondary monitor makes a lot of sense... Perhaps it would be better to simply remove the Apps button from the dash on secondary monitors.

In any case, I think I would rather wait for @micheleg to review the changes and give some feedback on how it is implemented. We can then look at improving the remaining bits.

from dash-to-dock.

Unfortunately I haven't had the opportunity to look into this yet. I will try to do it soon.

from dash-to-dock.

@franglais125 thank you for working on this! However, I'm perhaps slightly confused.

How do you get the dash to show on all you monitors? I was expecting in the "Show the dock on" pull-down there would be a new option for "All Monitors" or similar?

Again, thank you to all involved. I think if we can get this branch merged and the windows previews to be activated via hover it will be perfect ;-)

Thank you all!

Mike

from dash-to-dock.

Yeah, that was my fault. You have to be smart enough to grab the correct branch ;-)

So far works well. As @luisfpg mentioned above some of Ubuntu's per-monitor Unity magic would be icing on the cake.

Regardless, thank you. Great work.

Mike

from dash-to-dock.

A few days on continuous use at work (3 monitors) and no problems I've noticed.

+1

Merge it.

from dash-to-dock.

@jonnjonzzn thanks for the feedback!

I guess the "icing on the cake" you are referring to is to have some kind of indicator to know on which monitor the app is running?
I don't think I'll implement something like this in the short term, but once (and if) this is merged, I can have a look at it.

from dash-to-dock.

@franglais125 I was potentially thinking the dot(s) below or background of running applications could be a different color for apps running on the current monitor. Certainly not very important and perhaps not even a good idea with the overhead to the code. Just a thought.

Again, thank you for all your work on this. It is very much appreciated.

from dash-to-dock.

@franglais125 I have just updated my workstation at work with a fresh install of fedora 25. I just installed your latest update/rebase and will pass along my feedback. Initially everything is working as expected and looks good.

Thank you.

Michael

from dash-to-dock.

@jonnjonzzn thanks for lettming me know!

To all: again, following recent commits, I rebased multi-monitor today.

from dash-to-dock.

i installed yesterday, other than what appeared to be some conflicts while trying to install it, the extension is working beautifully so far

from dash-to-dock.

Found a bug with overview on second monitor:

from dash-to-dock.

@cra0zy Are you referring to the overlap between the dash and the window?
If so, then I think it's a duplicate of #410.

from dash-to-dock.

@cra0zy Are you referring to the overlap between the dash and the window?
If so, then I think it's a duplicate of #410.

Yup.

from dash-to-dock.

Thanks, the problem does not originate from the multi-monitor implementation, but still, I'll try to see if I can fix this.

from dash-to-dock.

Tested this for a few days now, no problems so far. Great work, thanks!

from dash-to-dock.

For anyone interested: I just rebased the multi-monitor branch again to include the latest commits from the master branch.

Cheers!

https://github.com/franglais125/dash-to-dock/tree/multi_monitor

from dash-to-dock.

thanks man, any ETA on when itll get accepted into master?

from dash-to-dock.

@thejacer87 unfortunately, no. AFAIK, @micheleg doesn't have an extra monitor to test the changes. The modifications are not minor, and even though the multi-monitor branch has received positive feedback so far, it is difficult to review and merge code that you can't test properly.

I'm doing my best to keep it up to date until it can be merged (hopefully).

from dash-to-dock.

sounds good, keep up the good work

from dash-to-dock.

@franglais125 Tested with Ubuntu 16.04 (gnome 3.18.3) and working perfect! Thanks buddy

from dash-to-dock.

I do agree this is a nice feature to have, and I'd like to see it merged (@gabrielmoreira I'd like to have three monitor too!)

@franglais125 how do you judge your branch on a scale of "it's an hack"..."I thoroughly thought about how to structure things"?

I haven't looked at the code recently. I guess we are somewhere in between, also because you probably tried to not disrupt too much the current code structure. So my question is, would a bigger core reorganization to accommodate the existence of multiple docks be desirable?

More generally, what kind of multimonitor are we looking for? Duplicated dock on all screen? Screen restricted dock? Dock moving from monitor to monitor (à la MacOS if I remember correctly). Should it depend on the workspace settings (workspace on secondary monitors or not)?

from dash-to-dock.

Great work! That's what I'm looking for, thank you!

from dash-to-dock.

This is great!
An extra nice touch might be the option to have different positions on each monitor. For example, on my left monitor i'd like to keep the dock to the left, on the right monitor i'd keep it to the right. That way, it doesn't "catch" my mouse when moving it from right to left monitor.

from dash-to-dock.

How can i try this new functionality or when do you plan to push an update to the gnome extensions store? I tried building from sorce and installing manually on ubuntu-gnome, but it did not appear to have any differences to the official version.... I think, I did something wrong....

from dash-to-dock.

It works, thanks!
Looks like I forgot to check out the right branch 🙈

from dash-to-dock.

Hi everyone!

The work to enable multi-monitor support has been included in the master branch. Thanks a lot @micheleg for the review and inclusion of this feature!
In the testing I did things seemed to work fine, but if people can test more and report on bugs you find,it would be great to make sure we haven't broken anything.

We can perhaps keep this open until a new version is uploaded to e.g.o, so that it's easier to find for people looking for this issue.

Cheers!

from dash-to-dock.

What is the behaviour with the extension disabled? Does the icon show up in the default dash (inside the overview)?

from dash-to-dock.

@micheleg I think you meant to write the last comment in #483 ?

from dash-to-dock.

Is it possible for the app drawer to be displayed on the second monitor?

from dash-to-dock.

@franglais125 Yes, too many tabs github tabs open...

from dash-to-dock.

@cra0zy You mean the grid of applications you get in the overview?

from dash-to-dock.

@cra0zy You mean the grid of applications you get in the overview?

yissss

from dash-to-dock.

does that fact that this is in master mean that enabling it from the gnome extensions website will have this feature in there?

edit: just tried and didn't seem to work. i just realized what "e.g.o" was in franglais last post.

any ETA for the ego release?

from dash-to-dock.

I feel forgotten :(

from dash-to-dock.

@cra0zy While the answer to your question could be "yes it's possible", I don't think it is straightforward. I'd love to implement it, but I doubt it will be worth the trouble.

Perhaps I'm mistaken, but the (short) look I took at the code looked like a hard thing to implement.

from dash-to-dock.

@cra0zy this is something that could be implemented, although I'm not sure how easy it is. I've always tried to avoid disrupting too much the default shell behaviour and not to do things that are outside the scope of this extension. I will consider it, but I'll think twice before doing it. Would you mind opening an issue for it?

from dash-to-dock.

#492

from dash-to-dock.

Found a bug... When you have two windows on the second screen open and you tap the super key, the left windows' close button becomes unaccessible. This happens, because the dash just overlays the screen but should pad the screen to the right. My dash settings are like classic unity: a static dock on the left, full length top to bottom, always visible, both monitors enabled.

from dash-to-dock.

@uloco Indeed, this was reported some time ago #410, we still need to fix it. The bug is also present even if you don't use "Show on all monitors".

from dash-to-dock.

Found a bug?: Minimizing animation is always tied to one of the docks even if you drag the window to a second monitor. Not sure if you can do anything to fix it tho.

from dash-to-dock.

@cra0zy I forgot to comment about that. Normally windows should minimize to the corresponding dock (screen where the window is).

Can anybody else reproduce this problem? On my system it's working fine, i.e. the window minimizes to the correct dock (assuming you are using multiple docks obviously)>

from dash-to-dock.

Just FYI I am running GNOME 3.24

from dash-to-dock.

@cra0zy I just tried on Gnome 3.24 and still can't reproduce the problem. If you are still seeing that behavior, can you open a new issue and describe what's happening?

from dash-to-dock.

Hi everyone!

The work to enable multi-monitor support has been included in the master branch. Thanks a lot @micheleg for the review and inclusion of this feature!
In the testing I did things seemed to work fine, but if people can test more and report on bugs you find,it would be great to make sure we haven't broken anything.

We can perhaps keep this open until a new version is uploaded to e.g.o, so that it's easier to find for people looking for this issue.

Cheers!

Does it work on gnome-shell 3.18?

Thanks!

from dash-to-dock.

Please release the multi monitor version, so I can ditch Unity :)

from dash-to-dock.

@luisvasquez it should work on 3.18, but I didn't test that in a while. Let me know if you find problems related to multi-monitor!

from dash-to-dock.

multi_monitor branch is gone?

from dash-to-dock.