Infinite loop in de.undercouch.bson4jackson.io.DynamicOutputBuffer.putUTF8(int, String) about bson4jackson HOT 13 CLOSED

It seems this loop does not handle the underflow condition correctly. I will check this and get back to you.

Cheers,
Michel

from bson4jackson.

I'm not sure if an underflow is actually the problem here. I can't reproduce it. Do you know anything about your input data at that point?

Michel

from bson4jackson.

Does the problem still persist?

Michel

from bson4jackson.

Yes, the problem persist.

My input data can be really different, text, image, binary content...
But I can't get a sample of data which always produce the problem. For the same input it can work or not.

Yoann

from bson4jackson.

Sounds like a multi-threading issue. Do you use bson4jackson from multiple threads at the same time? Which version of bson4jackson do you use? I fixed a multi-threading issue recently in this commit. The current version that includes this fix is 2.3.1.

Michel

from bson4jackson.

Yes i use it from multi-thread at the same time.
I will try next week the 2.3.1

Yoann

from bson4jackson.

Cool. Looking forward to hear from you.

Michel

from bson4jackson.

Did it work?

Michel

from bson4jackson.

Closing this issue due to inactivity.

Michel

from bson4jackson.

That bug is alive and we have a piece of data that causes infinite loop in de.undercouch.bson4jackson.io.DynamicOutputBuffer.putUTF8(int, String). This has nothing to do with multithreading. It has to do with memory management during encoding. Would you be able to fix the problem if we shared the data sample?

from bson4jackson.

The file size is ~320K. Not sure how best to share it with you.

from bson4jackson.

I submitted a PR #79 . Not sure why it the CI fails. I left some comments in the PR. The trigger in our case is a sequence of 3 byte UTF8 chars side by side such that it causes OVERFLOW. The logic in putUTF8 never recovers from this situation because the 4 byte buffer end up having a limit of 1 and after a flip it becomes a 1 byte buffer. If OVERFLOW is by 1 or 2 bytes your code will never allocate additional memory

from bson4jackson.

After removing the second change the CI build passes. I believe replacing rewind() with clear() is an obvious thing. It fixes the infinite loop problem for me. Please publish a new version ASAP. We use your library in prod and it served us well - good job at developing and maintaining this!

from bson4jackson.