Comments (6)
Thanks for the suggestion.
Added in the latest release (v2.3.3).
from isubrip.
Thanks for the suggestion. Added in the latest release (v2.3.3).
Thanks! Though I found a small issue when the movie title contains the year. You'll get double years, in both the ZIP and the VTT files, but it's not really that important. It's more important having the year in the ZIP file name.
iTunes kinda sucks regarding the year data. The year on the movie page seems to sometimes be the region's release date (or digital release maybe?). So you get silly things like "Fantasia (1940)" having a release date of 1990. So in a way it's good to have double years, but it's kinda annoying with the same year twice.
They aren't consistent with year in title. It's mostly used differentiate movies from the 2010s/1990s from movies in 1950+
You can get e.g. The Third Man from 1949 with a release date of 2015. The.Third.Man.2015.iT.WEB.zip
https://itunes.apple.com/se/movie/the-third-man/id1490947650?l=en
Cinderella.1950.1950.iT.WEB
https://itunes.apple.com/se/movie/cinderella-1950/id1339827782?l=en
Dumbo.1941.1946.iT.WEB
https://itunes.apple.com/se/movie/dumbo-1941/id1338970937?l=en
Fantasia.1940.1990.iT.WEB
https://itunes.apple.com/se/movie/fantasia-1940/id1429270511?l=en
from isubrip.
I checked a few movies. If you scraped copyright instead of released year you'd get the correct year. Though not all movies have the copyright year. So maybe switch to copyright year and have released year as fallback, but even copyright year won't always be correct, e.g.
https://itunes.apple.com/se/movie/superman-batman-apocalypse/id820997757?l=en
But better that it's now with a lot of old movies having wrong year.
from isubrip.
Thanks for reporting.
I've pushed a fix (6a0bc2d) for cases where thesame year is already in the title (like Cinderella.1950.1950.iT.WEB
).
I actually had this in mind while working on the fix for this issue, but I forgot to implement it.
As for cases where the year in title and the release year on the metadata mismatch, it will remain as it currently is (like Dumbo.1941.1946.iT.WEB
for example) for now, as I don't have a simple solution in mind at the moment.
The original release year like (1941 in Dumbo's case) should be the correct one, but taking the release year from the title is problematic as it could be part of the title (for example: "2012" and "1917" are both movie names).
Using the copyright is not reliable enough.
I'll keep that in mind though and see if I can find a solution.
from isubrip.
Using the copyright is not reliable enough.
How so? That it's available or accuracy?
I checked copyright year for a few iTunes movies on US store and they seem to be correct. One was off by one year.
I've done 1.4k rips on the Swedish store. I'd say about 1/3-1/4 have incorrect year using released. A lot of them are off by 1-2 year (because of Swedish region released date) but a lot also have decades in difference.
from isubrip.
@MichaelYochpaz I checked a few more movies (Swedish store) and a lot them have released year one year later than copyright year. "Copyright year" is what IMDB, TMDB, Wikipedia have. IMO released year is what's not reliable.
If you only look at the US store I guess you could say the few times it's incorrect makes it "unreliable".
In the Swedish store (and probably other languages) the year is wrong a lot.
There are probably a lot more than I've noticed. It's easy to miss 1-2 years off the correct year for movies you haven't memorized.
from isubrip.
Related Issues (20)
- [Issue]: No matching subtitles found HOT 11
- [Issue]: Can't save zip file to a different drive HOT 3
- [Feature Request]: Skip forced subtitles not matching original or selected language HOT 4
- [Issue]: Apple TV IDs shorted than 24 characters are not recognized HOT 2
- [Issue]: Cannot download english version of subtitles HOT 1
- [Feature Request]: Separate subtitles by Country Codes. HOT 5
- [Question]: It showed me error, how to fix it? HOT 5
- [Issue]: whenever isubrip finds a subtitles file, python crashes. HOT 4
- [Question]: CC subtitles not downloaded HOT 1
- [Issue]: Redirect URL not found? HOT 9
- [Issue]: Web source missing from filename HOT 3
- [Feature Request]: Output formatting to improve information understanding. HOT 1
- [Issue]: Fix bug in "Error: No iTunes playables could be found." error/warning message. HOT 3
- [Issue]: Fix a possible error or bug in the subtitle download order. HOT 1
- Possible support also for Seven 64bit HOT 3
- [Issue]: 38;20m HOT 4
- [Feature Request]: information on release dates from all countries HOT 1
- [Feature Request]: הורדת "תרגום" אחרי סריקה של כל המדינות HOT 1
- [Question]: Do you have any idea how to track all countries? HOT 4
- [Feature Request]: Support TV Shows HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from isubrip.