Giter Club home page Giter Club logo

Comments (3)

michaelgrosner avatar michaelgrosner commented on May 13, 2024

Part of the problem is that there are hardcoded constants throughout the code which assume that the price of the currency pair you are trading is about $100-$1000. Making it configurable is on my list of things to do.

from tribeca.

holoiii avatar holoiii commented on May 13, 2024

Where are some of these constants? I'd love to help out with this feature, but could use a few pointers.

from tribeca.

michaelgrosner avatar michaelgrosner commented on May 13, 2024

@holoiii the problems is these constants and assumptions are spread pretty evenly throughout the codebase, and it requires a substantial refactoring of how gateways are constructed and currency pairs are validated. I put up a PR #98 to address this. Please take a look at it.

from tribeca.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.