Giter Club home page Giter Club logo

Comments (5)

michael-rapp avatar michael-rapp commented on June 13, 2024

I guess it should be possible to select an image from the gallery as well as to capture an image using the camera, right? This will cause a dialog to be shown, which allows to select, what app should be used to select/capture the image. It is not necessary to open another dialog beforehand, which shows the current image and allows to delete it, is it?

Because it is not recommended to store image data in shared preferences, only the path to image files will be stored. The images themselves will stored on the device's storage instead. I guess it would be best to use the app's private directory. When choosing an image from an other location the file will be copied into the private directory. This prevents the image from getting lost when it is deleted by an other app.

from androidmaterialpreferences.

Rainer-Lang avatar Rainer-Lang commented on June 13, 2024

I describe the workflow (for me):

  1. User selects image (gallery/camera)
  2. crop image (with https://github.com/IsseiAoki/SimpleCropView)
  3. save the image in private app folder + save the path to image in preference + show thumbnail in settings-view

from androidmaterialpreferences.

michael-rapp avatar michael-rapp commented on June 13, 2024

Alright, if cropping is required, this adds additional complexity and an additional dialog has to be shown. I will think about this.

from androidmaterialpreferences.

Rainer-Lang avatar Rainer-Lang commented on June 13, 2024

see here: #7

from androidmaterialpreferences.

michael-rapp avatar michael-rapp commented on June 13, 2024

I thought about this issue in a more detailed way and I realized, that implementing this preference would require to deal with issues which go far beyond the scope of all other preferences, which are already provided by the library. For example, it would be necessary to cope with error handling (e.g. what happens if the gallery app can not be opened or if copying files fails). Furthermore, I can imagine very different use cases for picking images and I don't think it is possible to fit all needs with one implementation. Therefore I decided to not implement such a preference because I want to keep the library simple (it only provides simple views instead of implementing complex use cases) and because I don't have enough time to deal with all the issues in a detailed way at the moment. I am sorry!

from androidmaterialpreferences.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.