Integer Overflow when hashing a large TFilestream about delphiencryptioncompendium HOT 5 CLOSED

Fixed in development branch now.

from delphiencryptioncompendium.

Hi,

Depending on your Delphi version, you will need to define integer overflow, I got the same issue with Delphi 11 but no error on 10 : https://docwiki.embarcadero.com/RADStudio/Alexandria/en/Overflow_checking_(Delphi)

from delphiencryptioncompendium.

I don't know (yet) how a TFileStream or TStream works internally. If it holds all data in RAM that might explain it, but I'm not sure about this yet.

from delphiencryptioncompendium.

Ok, I took your code now and created a test project. I used a > 600 MB file and it shows your problem. It is in TDECHash.Increment8(var Value; Add: UInt32);

I added a possible fix now, see development branch. But I'm not sure yet this is what we want to have. A discussion about this was started on German Delphipraxis.net forums now. If they say my proposed solution is ok, we'll take it and can close this report. My proposed fix at least runs your test case fine and doesn't create any new problems with the existing unit tests.

from delphiencryptioncompendium.

Since this is fixed in development branch and nobody objected the way it was fixed since before Christmas I close this issue now.

from delphiencryptioncompendium.