Comments (2)
I guess this is a typo or something that's never implemented. I've checked all routers and they all do this (including older versions):
public function addRoute(Route $route) : void
{
$this->routesToInject[] = $route;
}
I guess you can even call it a feature to add more routes after you matched a route already :)
And to be honest, why would you have that check? When adding a lot of routes it only creates overhead.
Originally posted by @geerteltink at zendframework/zend-expressive-fastroute#60 (comment)
from mezzio-fastroute.
So it'd be fine to remove this part of the docblock from zend-expressive?
Originally posted by @MatthiasKuehneEllerhold at zendframework/zend-expressive-fastroute#60 (comment)
from mezzio-fastroute.
Related Issues (9)
- Fix uri generation for custom parser HOT 1
- `FastRouteRouter#getCacheFile` to provide cache location HOT 3
- Dependency Dashboard
- Route option values should be retrievable from request attribute HOT 2
- Unreliable cache availability check HOT 7
- Psalm integration
- PHP 8.0 support
- Broken link on the documentation page
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mezzio-fastroute.