Comments (3)
same here, ready to prepare a patch
Original comment by [email protected]
on 18 Sep 2013 at 10:16
from lightopenid.
In my opinion, getter and setter functions would decrease readability without
offering any real benefit. I can't really think of any situation where someone
would spend significantly more time because he's misspelled a variable name.
If and when php will implement proper getter/setter syntax (not defining
getVariable/setVariable functions) functions, I will use them.
Your concern about hiding the real presence of fields is somewhat valid though,
but can be solved by implementing __isset. And that's what I'll do (or you can
submit a patch/pull request, if you want to).
Original comment by [email protected]
on 19 Sep 2013 at 11:27
from lightopenid.
at least could you please throw an exception on access to not existent fields?
It is really easy fix, just to add one more 'else'
thanks
Original comment by [email protected]
on 19 Sep 2013 at 12:08
from lightopenid.
Related Issues (20)
- add composer support HOT 1
- wrong mimetype check in openid.php ? HOT 3
- Use Steam as provider HOT 1
- #-comments HOT 6
- returning clamed_id is a wrong approach HOT 5
- LightOpenID magic properties do not work with Twig template engine due to lack of __isset
- New release HOT 2
- keep waiting for localhost HOT 2
- Validation fails when there are accent in the required variable HOT 2
- Yahoo OpenID not working on newer versions of PHP/cURL [patch proposed]
- The regular expressions in htmlTag parse some valid responses incorrectly
- Support for OpenID Connect? HOT 2
- How to select eid applet language ? HOT 1
- Unregistered domain error HOT 1
- (LightOpenId) eID-Applet does not return some eid's data ...
- gitorious no longer existing HOT 5
- Tag a release? HOT 1
- PHP 7.4.0 - get_magic_quotes_gpc() function is deprecated.
- PHP 8.0.3 - Deprecated: Required parameter $update_claimed_id
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lightopenid.