Giter Club home page Giter Club logo

Comments (9)

slaaavyn avatar slaaavyn commented on May 24, 2024 1

The problem is actual, please approve PR #58

from nestjs-opentelemetry.

izevg avatar izevg commented on May 24, 2024

Confirming.

Temporary solution: rollback/lock the @opentelemetry/sdk-trace-base version on 1.0.1, as per this lib package-lock.json
Proper way: update all the used @opentelemetry/* packages to the actual versions & fix the issues. (FYI: sdk-trace-base is on v1.7.0 already, and contains A LOT of breaking changes in between versions)

@MetinSeylan could you please be so kind? 🙏🏻

from nestjs-opentelemetry.

MetinSeylan avatar MetinSeylan commented on May 24, 2024

Hey 🖖 fixed with new version, but keep in mind new version required nestjs 9

from nestjs-opentelemetry.

codeprefect avatar codeprefect commented on May 24, 2024

Hi @MetinSeylan,

This issue persists even on nestjs v9.
As a stop-gap for my work, I forked this repo, and updated all the dependencies, which appears to fix it for my case.
I currently have the package installed with

"dependencies": {
  ...
  @metinseylan/nestjs-opentelemetry": "https://github.com/codeprefect/Nestjs-OpenTelemetry#head=update-otel-deps",
  ...
}

Happy to rollback once we have it fixed here.

from nestjs-opentelemetry.

murar8 avatar murar8 commented on May 24, 2024

I can confirm the issue persists for me too.

from nestjs-opentelemetry.

amitzig avatar amitzig commented on May 24, 2024

Any update on this?

from nestjs-opentelemetry.

valanto avatar valanto commented on May 24, 2024

@MetinSeylan Any update on this? The issue persists on NestJS 9. Thanks!

from nestjs-opentelemetry.

slaaavyn avatar slaaavyn commented on May 24, 2024

Solved my problems by using opentelemetry without this library.
As an example I use https://github.com/polyflix/video/blob/5d81560edca81e2d49a406b3a62b130f6839baf3/src/main/config/tracing.config.ts

from nestjs-opentelemetry.

murar8 avatar murar8 commented on May 24, 2024

For anyone still having this issue a temporary solution is to lock the peer dependencies in your package.json to the same version as the library (notice the missing ^)

  "dependencies": {
    "@metinseylan/nestjs-opentelemetry": "^3.0.0",
    "@opentelemetry/sdk-trace-base": "1.9.1"
  },

from nestjs-opentelemetry.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.