Comments (6)
Interesting fact: if you declare gem "rolify"
before gem "less-rails"
in the Gemfile, it works.
I guess it's a matter of initializers loading order.
from less-rails.
Thanks for posting this. I tried this approach 64081fe and published v2.4.1 and it failed. Then I did dfb9a5e along with the test project @raykin put in #62 and it his issue was fixed. After some deep digging, I think after load_config_initializers
was a poor decision on my part. From @raykin's project, I could see that the core Railtie load_config_initializers
hook was being called 4 times or so.
I then decided that what I really wanted was a before on that and once I changed it, everything just worked. Please test v2.4.2 with your issue and let me know if it works. Again, thanks for looking into this.
from less-rails.
@metaskills This must have regressed: rails/rails#35025
If this is caused by initializer 'less-rails.before.load_config_initializers', :before => :load_config_initializers, :group => :all
, then a couple of comments:
- gem initializers already run before app initilializers, so why is this before needed?
- rails is probably at fault because this should not prevent the enforcement of the guarantee that app initializers will run after gems, but a fix in less-rails would be helpful
from less-rails.
Sorry, it has been awhile. Is there something mintiest-spec-rails needs to do?
from less-rails.
You mean less-rails?
If you look through rails/rails#35025, the culprit is initializer 'less-rails.after.append_assets_path', :after => :append_assets_path
. This after condition ends up causing app initializers to run before at least some gem initializers (geocoder in the test repo)
But rafaelfranca says there's no guarantee that app inits will run after gem inits, so I suppose technically there's is no issue, however I think practically, it would be nicer if less-rails did not have such an effect (if it's avoidable).
from less-rails.
Whoops right, repo confusion.
from less-rails.
Related Issues (20)
- release 2.8.0 to rubygems HOT 8
- Tests for Ruby 2.2+ and suppport for NOT using therubyracer HOT 4
- @import remote file fails with (less) option HOT 1
- Is therubyracer needed to be installed with less-rails? HOT 1
- N/A
- less-rails doesn't load with Ruby 2.4.0 HOT 6
- Doesn't work with sprockets 4 beta HOT 3
- Could we use other javascript runtime(e.g. mini_racer)? HOT 2
- Sprockets 3 compatibility HOT 1
- Silence warnings HOT 1
- less-rails 3.0.0 in Rails 4 project causing Asset logical path has no extension error on asset compilation HOT 4
- Uplifting from 2.8 to 3.0 causes issues with precompiling. HOT 2
- error evaluating function `data-uri`: Optional dependency "mime" is required for .svg HOT 1
- Version 2.8.0 is showing deprecation warning from register_engine HOT 2
- rails s command issue HOT 2
- less-rails initializer causes load_config_initializers to run too early, before other gem initilizers HOT 1
- less-rails not working with Rails 6 - undefined method `pathname' HOT 13
- less-rails 5.0 require sprocket 3 HOT 1
- Any way to remove/avoid therubyracer? HOT 2
- heroku deploy failing with therubyracer dependency HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from less-rails.