Giter Club home page Giter Club logo

Comments (5)

discordier avatar discordier commented on May 25, 2024

Yes and that's intentional.

With your defaults, all filter settings will show no entry (as you supplied the empty array) and of those "no items" it will show all.

Therefore it is IMO best to have those two parameters mandatory and not supply a default to avoid confusion as it even confused you.

from core.

davidmaack avatar davidmaack commented on May 25, 2024

OK, this makes sense. I greped the sources of the nightly build (14.02.2013) for 'getFilterOptions()' and found five matches where no parameters are set:

MetaModel.php line 560
MetaModelfilterSettingFromTo.php line 127
MetaModelfilterSettingTags.php line 58 and line 109
MetaModelFilterSettingText.php line 123

I guess these classes want to get the filter from all id´s but Il´ll have a look at it later

from core.

discordier avatar discordier commented on May 25, 2024

You have fixed tags, what of the others does still remain?

from core.

davidmaack avatar davidmaack commented on May 25, 2024

MetaModelFilterSettingText.php line 118

from core.

discordier avatar discordier commented on May 25, 2024

And that line appears to be entirely useless...
On the other hand, the filter_text is non functional as of now, therefore I guess we can close this ticket.

from core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.