Comments (6)
danfinlay
commented on July 30, 2024
I probed around a bit today and couldn’t find any evidence that this isn’t deallocated, the element is definitely torn down by react on view change.
On Mar 2, 2016, at 3:25 PM, kumavis [email protected] wrote:
make sure we aren't rendering even when he is off screen. all your battery gone!
—
Reply to this email directly or view it on GitHub MetaMask/metamask-ui#2.
from logo.
kumavis
commented on July 30, 2024
element is torn down but i think three.js is still rendering to an off-dom element
from logo.
danfinlay
commented on July 30, 2024
Oh, interesting! I didn’t realize this was possible!
On Mar 2, 2016, at 4:45 PM, kumavis [email protected] wrote:
element is torn down but i think three.js is still rendering to an off-dom element
—
Reply to this email directly or view it on GitHub MetaMask/metamask-ui#2 (comment).
from logo.
kumavis
commented on July 30, 2024
also i think the mouse tracking is still going on
from logo.
kumavis
commented on July 30, 2024
im more concerned with the rendering though
from logo.
danfinlay
commented on July 30, 2024
Yeah I guess it lacks tear-down hooks in general, which would need to be passed up to the react component. That’s a good point.
On Mar 2, 2016, at 4:46 PM, kumavis [email protected] wrote:
also i think the mouse tracking is still going on
—
Reply to this email directly or view it on GitHub MetaMask/metamask-ui#2 (comment).
from logo.
Related Issues (14)
- Action required: Greenkeeper could not be activated 🚨
- Creating a demo with a custom .obj file
- Reactjs some error
- performance issue HOT 3
- Who made this? HOT 1
- mouse tracking not working in vue.js HOT 2
- Even handler leak HOT 1
- Description has exposed HTML HOT 1
- Rendering errors when modifying fox.obj HOT 2
- Add LICENSE file
- incorporate dans security fox example
- Code isn't improved for react HOT 1
- Please add a license HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from logo.