Comments (4)
fedepaol
commented on August 22, 2024
Skipped are not dumped anyway.
Can you make concrete examples of what we should remove?
from frr-k8s.
karampok
commented on August 22, 2024
IMO all the STEP output is not needed, we should only see the description and messages if failed something
2024-07-16T19:20:05.5415647Z �[0mReceiving routes �[38;5;243mReceiving IPs �[0mWorks with external frrs �[0m�[1mIPV4 - receive ips from all�[0m
2024-07-16T19:20:05.5418988Z �[38;5;243m/home/runner/work/frr-k8s/frr-k8s/e2etests/tests/receiving.go:138�[0m
2024-07-16T19:20:05.5420552Z �[1mSTEP:�[0m Clearing any previous configuration �[38;5;243m@ 07/16/24 19:20:05.54�[0m
2024-07-16T19:20:13.0837101Z �[1mSTEP:�[0m pairing with nodes �[38;5;243m@ 07/16/24 19:20:13.083�[0m
2024-07-16T19:20:17.0548644Z �[1mSTEP:�[0m checking nodes are peered with the frr instance ibgp-multi-hop �[38;5;243m@ 07/16/24 19:20:17.054�[0m
2024-07-16T19:20:27.2364519Z �[1mSTEP:�[0m checking nodes are peered with the frr instance ebgp-single-hop �[38;5;243m@ 07/16/24 19:20:27.235�[0m
2024-07-16T19:20:27.3670570Z �[1mSTEP:�[0m checking nodes are peered with the frr instance ibgp-single-hop �[38;5;243m@ 07/16/24 19:20:27.366�[0m
2024-07-16T19:20:27.4700250Z �[1mSTEP:�[0m checking nodes are peered with the frr instance ebgp-multi-hop �[38;5;243m@ 07/16/24 19:20:27.469�[0m
2024-07-16T19:20:27.5743439Z �[1mSTEP:�[0m validating �[38;5;243m@ 07/16/24 19:20:27.574�[0m
2024-07-16T19:20:27.5744607Z �[1mSTEP:�[0m Checking routes [192.168.2.0/24 192.169.2.0/24] from ibgp-multi-hop �[38;5;243m@ 07/16/24 19:20:27.574�[0m
2024-07-16T19:20:29.3820582Z �[1mSTEP:�[0m Checking routes [192.168.2.0/24 192.169.2.0/24] from ebgp-single-hop �[38;5;243m@ 07/16/24 19:20:29.381�[0m
2024-07-16T19:20:31.2170088Z �[1mSTEP:�[0m Checking routes [192.168.2.0/24 192.169.2.0/24] from ibgp-single-hop �[38;5;243m@ 07/16/24 19:20:31.216�[0m
2024-07-16T19:20:33.0266870Z �[1mSTEP:�[0m Checking routes [192.168.2.0/24 192.169.2.0/24] from ebgp-multi-hop �[38;5;243m@ 07/16/24 19:20:33.026�[0m
2024-07-16T19:20:34.8438135Z �[1mSTEP:�[0m Cleaning before retesting with the config splitted �[38;5;243m@ 07/16/24 19:20:34.843�[0m
2024-07-16T19:20:34.8569337Z �[1mSTEP:�[0m checking node frr-k8s-control-plane is not peered with the frr instance ibgp-multi-hop �[38;5;243m@ 07/16/24 19:20:34.856�[0m
2024-07-16T19:20:39.5003475Z �[1mSTEP:�[0m checking node frr-k8s-worker is not peered with the frr instance ibgp-multi-hop �[38;5;243m@ 07/16/24 19:20:39.5�[0m
2024-07-16T19:20:39.6757891Z �[1mSTEP:�[0m checking node frr-k8s-worker2 is not peered with the frr instance ibgp-multi-hop �[38;5;243m@ 07/16/24 19:20:39.675�[0m
2024-07-16T19:20:39.8579667Z �[1mSTEP:�[0m checking node frr-k8s-control-plane is not peered with the frr instance ebgp-single-hop �[38;5;243m@ 07/16/24 19:20:39.857�[0m
2024-07-16T19:20:40.0189475Z �[1mSTEP:�[0m checking node frr-k8s-worker is not peered with the frr instance ebgp-single-hop �[38;5;243m@ 07/16/24 19:20:40.018�[0m
2024-07-16T19:20:40.1803157Z �[1mSTEP:�[0m checking node frr-k8s-worker2 is not peered with the frr instance ebgp-single-hop �[38;5;243m@ 07/16/24 19:20:40.18�[0m
2024-07-16T19:20:40.3520681Z �[1mSTEP:�[0m checking node frr-k8s-control-plane is not peered with the frr instance ibgp-single-hop �[38;5;243m@ 07/16/24 19:20:40.351�[0m
2024-07-16T19:20:40.4997766Z �[1mSTEP:�[0m checking node frr-k8s-worker is not peered with the frr instance ibgp-single-hop �[38;5;243m@ 07/16/24 19:20:40.499�[0m
2024-07-16T19:20:40.6518850Z �[1mSTEP:�[0m checking node frr-k8s-worker2 is not peered with the frr instance ibgp-single-hop �[38;5;243m@ 07/16/24 19:20:40.651�[0m
2024-07-16T19:20:40.8080870Z �[1mSTEP:�[0m checking node frr-k8s-control-plane is not peered with the frr instance ebgp-multi-hop �[38;5;243m@ 07/16/24 19:20:40.807�[0m
2024-07-16T19:20:41.0125495Z �[1mSTEP:�[0m checking node frr-k8s-worker is not peered with the frr instance ebgp-multi-hop �[38;5;243m@ 07/16/24 19:20:41.012�[0m
2024-07-16T19:20:41.1950296Z �[1mSTEP:�[0m checking node frr-k8s-worker2 is not peered with the frr instance ebgp-multi-hop �[38;5;243m@ 07/16/24 19:20:41.194�[0m
2024-07-16T19:20:41.4551330Z �[1mSTEP:�[0m checking nodes are peered with the frr instance ibgp-multi-hop �[38;5;243m@ 07/16/24 19:20:41.454�[0m
2024-07-16T19:20:51.7067747Z �[1mSTEP:�[0m checking nodes are peered with the frr instance ebgp-single-hop �[38;5;243m@ 07/16/24 19:20:51.706�[0m
2024-07-16T19:20:51.8177306Z �[1mSTEP:�[0m checking nodes are peered with the frr instance ibgp-single-hop �[38;5;243m@ 07/16/24 19:20:51.817�[0m
2024-07-16T19:20:51.9114235Z �[1mSTEP:�[0m checking nodes are peered with the frr instance ebgp-multi-hop �[38;5;243m@ 07/16/24 19:20:51.911�[0m
2024-07-16T19:20:52.0161110Z �[1mSTEP:�[0m validating with splitted config �[38;5;243m@ 07/16/24 19:20:52.015�[0m
2024-07-16T19:20:52.0162893Z �[1mSTEP:�[0m Checking routes [192.168.2.0/24 192.169.2.0/24] from ibgp-multi-hop �[38;5;243m@ 07/16/24 19:20:52.015�[0m
2024-07-16T19:20:53.9064779Z �[1mSTEP:�[0m Checking routes [192.168.2.0/24 192.169.2.0/24] from ebgp-single-hop �[38;5;243m@ 07/16/24 19:20:53.906�[0m
2024-07-16T19:20:55.7885683Z �[1mSTEP:�[0m Checking routes [192.168.2.0/24 192.169.2.0/24] from ibgp-single-hop �[38;5;243m@ 07/16/24 19:20:55.788�[0m
2024-07-16T19:20:57.6649385Z �[1mSTEP:�[0m Checking routes [192.168.2.0/24 192.169.2.0/24] from ebgp-multi-hop �[38;5;243m@ 07/16/24 19:20:57.664�[0m
2024-07-16T19:20:59.4636813Z �[38;5;10m• [53.923 seconds]�[0m
2024-07-16T19:20:59.4637620Z �[38;5;243m------------------------------�[0m
all checking and validating and cleaning config
from frr-k8s.
karampok
commented on August 22, 2024
The string passed to By is attached to the spec and can be displayed by Ginkgo when needed. If a test succeeds you won't see any output beyond Ginkgo's green dot. If a test fails, however, you will see each step printed out up to the step immediately preceding the failure. Running with ginkgo -v always emits all steps.
https://onsi.github.io/ginkgo/#documenting-complex-specs-by
one other idea is to remove the default -v option,
from frr-k8s.
github-actions
commented on August 22, 2024
This issue has been automatically marked as stale because it has been open 30 days
with no activity. This issue will be closed in 10 days unless you do one of the following:
- respond to this issue
- have one of these labels applied:
bug,good first issue,help wanted,hold,enhancement,documentation,question
from frr-k8s.
Related Issues (11)
- Advertise Service IPs HOT 8
- Wrong allowMode: all for outgoing prefixes HOT 3
- `SrcAddr` setting is not wired into the API HOT 6
- Skip check generated for changes coming from dependabot HOT 3
- Please build frr-k8s image for arm64 architecture HOT 1
- Replace github.com/pkg/errors with errors
- Failing CI with FRR 10.0.1 - Tracker only!
- Clean up the generated configuration files HOT 1
- hostNetwork Parameter HOT 16
- client-gen API not generated correctly
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from frr-k8s.