metal / metal-react Goto Github PK

I'm trying to use a react component that requires 16.0.0, but metal-react uses 15.6.2, which causes

Uncaught Error: Unable to find node on an unmounted component.

When trying to use two different versions of react together.

From a quick glance, it looks like the react component is never unmounted. I think we need to need to do something like call ReactDOM.unmountComponentAtNode when the wrapping Metal component is disposed.

If this case is actually handled in some other way or by some other mechanism, feel free to close this.

The react-dropzone component works well with metal-react, but it throws out the following warning:

Warning: Unknown props `elementClasses`, `events`, `visible` on <div> tag. Remove these props from the element. For details, see https://fb.me/react-unknown-prop
    in div (created by Dropzone)
    in Dropzone

All three of the props causing the warning are only being passed because all metal components have them, so we pass them over automatically via the bridge.

I’m sorry I have no time to actually test this, but I wanted to leave at least a note.

There are complex React components that expect functions as children. Those functions will be later called and of course they expect React elements to come out of those.

This means that your synchronous incremental-dom → React element transformation would happen just for the “first level” and not for the results of those functions.

ReactDOM.render(
  <Something>{ param => <span>{ param }</span> }</Something>,
  document.getElementById('something');
);