Giter Club home page Giter Club logo

Comments (3)

pjmolina avatar pjmolina commented on May 24, 2024 1

Good point! I will refactor the tests to make them simple.

from openapi3-ts.

pjmolina avatar pjmolina commented on May 24, 2024

They are defined in the interface, but they are optional in the spec. That why a minimal spec do not need to contain an explicit security nor externalDoc.
On the contrary, you can add them as needed using the addExternalDoc(), f.e.

from openapi3-ts.

nwayve avatar nwayve commented on May 24, 2024

Agreed, they are optional in the spec and defined in the interface as optional.
The test is "Build empty spec" which doesn't necessarily mean "Build minimal spec" which is why I thought those properties were missing.
Seems like they should be added to this test for an "empty spec" builder, regardless of them being optional. Either that or the properties components, tags, and servers should be removed in that test.

Perhaps the test should be "Builds the minimal spec" that expects the output object to be:

{
    openapi: "3.0.0",
    info: {
        title: "app",
        version: "version"
    },
    paths:  {}
}

from openapi3-ts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.