Comments (12)
+1
from metabase.
This needs a new error message HTML page to display when the token is invalid / expired. When that's done, we can introduce a new API endpoint to check to see if a token is expired, then write new frontend code to hit that endpoint, and show the new error page if needed, or otherwise show the appropriate change password form.
from metabase.
cool. @mazameli you want to take a quick pass at UX for this one and let us know how you think the frontend should respond?
basic problem is that someone loads up a url like mymetabase.com/auth/reset/:reset_token
and the token is expired. what should the user see when this happens?
from metabase.
?
from metabase.
Do we know if a token is invalid vs expired?
from metabase.
Yup, we track expiration_date
from metabase.
@mazameli Can you assign back to me once the designs are g2g
from metabase.
@camsaul will do
from metabase.
Mockup: https://www.dropbox.com/s/zh1q21iesd53uli/expired_password_reset_link_v1.png?dl=0
Sketch file: https://www.dropbox.com/s/qhbz8320pqu7ms3/expired_password_reset_link_v1.sketch?dl=0
from metabase.
can we also include a 404 or message when the token isn't in the system?
from metabase.
it already does that, it displays an �invalid token� message
On Sep 25, 2015, at 5:31 PM, Sameer Al-Sakran [email protected] wrote:
can we also include a 404 or message when the token isn't in the system?
�
Reply to this email directly or view it on GitHub.
from metabase.
Cool
On Friday, September 25, 2015, Cam Saül [email protected] wrote:
it already does that, it displays an �invalid token� message
On Sep 25, 2015, at 5:31 PM, Sameer Al-Sakran <[email protected]
javascript:_e(%7B%7D,'cvml','[email protected]');> wrote:can we also include a 404 or message when the token isn't in the system?
�
Reply to this email directly or view it on GitHub.—
Reply to this email directly or view it on GitHub
#594 (comment)
.
from metabase.
Related Issues (20)
- Option to Change Metabase Background Color Across the App HOT 1
- "Display Values" for FK Relationships Don't work if the Keys are Character Types HOT 1
- [BE] QP: column corresponding a metric aggregation should have the name of the metric
- Cumulative count grouping could be more intuitive
- BigQuery - Can't sync materialized views since 1.49.0
- Unable to filter on MongoDB ObjectId type fields if configured as Entity Key
- Unable to connect to MongoDB HOT 1
- JSON unfolding [Bigquery]
- BE flake: metabase.driver.bigquery-cloud-sdk-test/query-drive-external-tables
- [FE] Use default display for metrics
- [dc.js migration] Set missing values to zero setting does not work
- BE flakes: vertica QP tests flake with "Execution canceled by operator" error
- Add example and used functions to Lib.displayInfo for ColumnExtraction
- Redshift syncs different databases at once which causes confusion in the Metadata
- When updating a filter value in chill mode, the order of the columns is messed up
- truncated button text in JWT signing modal
- Composed MLv2 metadata providers cannot override a Setting value with `nil`
- [BE] dependentMetadata changes
- Dashboard Subscriptions Heading Cards - URI Illegal character in opaque part
- [FE] dependentMetadata changes
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from metabase.