Giter Club home page Giter Club logo

Comments (6)

ernscht avatar ernscht commented on July 3, 2024 1

hope this commit will fit your needs.

small change in configuration:

"plugin/stylelint-bem-namics": {
    "patternPrefixes": [],
    "helperPrefixes": [],
}

from stylelint-bem.

ernscht avatar ernscht commented on July 3, 2024

No, currently this is not possible.
But we are open for suggestions.

from stylelint-bem.

ernscht avatar ernscht commented on July 3, 2024

Thanks a lot for your PR.

I was not shure what you wanted to achieve exactly.
As i understand you now - with your boolean switch you still allow prefixes. Selectors like .block, .block__element are valid as well as .a-block and a-block__element, ...
We could also call them block names. So far so good.

Because the prefixes are a core concept in our naming convention your PR results in some inconsistencies.

  • The selector -block is rejected with the misleading message: "Expected class name "-block" to use the [prefix]-[block] syntax."
  • The selector --block is rejected with the message: "Expected class name "--block" to use the [prefix]-[block]--[modifier] syntax."
  • The selctor m--modifier shouldn't be rejected (it's rejected because m is a default prefix).
  • state-m--state, 'state-m-block' or m--modifier__block are also rejected because of the default configuration
  • ...

We're not at the end ;-)

and...
What do you think about disabling the individual configuration parameters?

"plugin/stylelint-bem-namics": {
    "patternPrefixes": false,
    "helperPrefixes": false,
}

from stylelint-bem.

nicholaslee119 avatar nicholaslee119 commented on July 3, 2024

Thanks for your explaining,
Actually, I was also considering those situations which you just mention,
When I recognize If we want to handle all the situation, we should refactor the function of parseClassName to let it parse class name into an object which is holding namespace/helper-prefix/pattern-prefix no matter if these prefixes exist.
but I was little rush to close those prefixes for my own needs, sorry for that.

and

I think it is a good idea to disabling the individual config in that way.

from stylelint-bem.

ernscht avatar ernscht commented on July 3, 2024

Version 4.0.0 released

from stylelint-bem.

nicholaslee119 avatar nicholaslee119 commented on July 3, 2024

That is great! Thank you

from stylelint-bem.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.