Comments (4)
Thanks for reporting this @mpenning !
Adding additional error conditions to the library methods could be seen as a breaking change; scripts otherwise working would stop working and this could be a big problem for folks who are not actively maintaining their scripts.
I don't think this is a security concern so it's harder to justify in that sense.
Did you have a suggested approach for handling this? Especially if you have a PR, that'd be helpful.
from dashboard-api-python.
Adding additional error conditions to the library methods could be seen as a breaking change; scripts otherwise working would stop working and this could be a big problem
Today, errors pass silently... and the result is VERY bad... the API returns partial results. That broke my script, but only because I knew exactly how many networks to expect. Imagine if I didn't catch the problem and it broke my production network.
Your claim is essentially "rejecting an invalid keyword could break a running script". The Zen of Python is very clear about this... "Errors should never pass silently... Unless explicitly silenced."
Logging a red error message to stdout seems rather unlikely to be a breaking change. Perhaps we can agree on this point.
from dashboard-api-python.
Adding an entry to the logger with that severity on such a scenario sounds like a good enhancement. Would you like to send a PR making that change?
from dashboard-api-python.
send a PR making that change?
Sounds good... it may take a while, I'm not familiar with the inner working of things
from dashboard-api-python.
Related Issues (20)
- createOrganizationPolicyObject type not found HOT 3
- function not passing 'type' variable HOT 1
- Early Access Supported Calls HOT 1
- Identity PSKs always return null for expiresAt field HOT 1
- 204-No Content error HOT 1
- Logging level HOT 2
- This library requires Python 3.7 at minimum and your interpreter version is 3.10.0 HOT 1
- aiomeraki.organizations.getOrganizationApiRequests failing after upgrading the SDK from 1.34.0 to 1.36.0 HOT 5
- aio/rest_session.py crashing on 400 errors with a UnboundLocalError HOT 6
- 'Wireless' object has no attribute 'getOrganizationWirelessDevicesEthernetStatuses' HOT 1
- Async operations gets a certificate error (while sync operation works fine) HOT 10
- Library crashes with AttributeError when API returns 404 with no body HOT 1
- meraki 1.39 shows support for python 3.7 HOT 1
- installation fails on Windows HOT 1
- batch.networks.removeNetworkDevices has the incorrect operation HOT 2
- passing pagination (total_pages) params to getOrganizationApplianceTrafficShapingVpnExclusionsByNetwork results in error HOT 4
- Minor Documentation Spelling Error HOT 2
- API Endpoint /organizations/{organizationId}/wireless/radio/autoRf/byNetwork Missing HOT 1
- Generator does not add the required query parameters to methods if the query parameters are arrays of objects HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dashboard-api-python.